Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated equinix metal manual docs #11

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

markcallen
Copy link
Contributor

Added info about creating a kind cluster for the manager cluster.

Added info about the ssh-key needing to be created in the console for the project.

@rossf7
Copy link
Contributor

rossf7 commented Dec 8, 2023

@markcallen Could you add a signoff to your commit to fix the DCO check?

LGTM (I don't have approval rights)

@leonardpahlke @nikimanoledaki PTAL

Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @markcallen!

@markcallen Could you add a signoff to your commit to fix the DCO check?

You can amend the last commit message to add the sign off afterward.

…ed info about the ssh-key

Signed-off-by: Mark C Allen <[email protected]>
@markcallen markcallen force-pushed the chore/update_equinix_doc branch from 74cc2c2 to 6a13d02 Compare December 8, 2023 22:49
@markcallen
Copy link
Contributor Author

@rossf7 updated for signoff.

Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikimanoledaki
Copy link
Contributor

nikimanoledaki commented Dec 9, 2023

Unfortunately the PR is still blocked because the commit sign-off must be verified e.g. with GPG:

The base branch requires all commits to be signed. Learn more about signing commits.

@markcallen
Copy link
Contributor Author

@nikimanoledaki added gpg

@leonardpahlke leonardpahlke merged commit a42174a into cncf-tags:main Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants