Remove deprecated registry API

[bart0sh]

No description provided.

[bart0sh]

This one is not as straightforward as the previous one, so @klihub please take a look. I'm not sure replacing GetRegistry with GetDefaultCache is correct approach.

[klihub]

This one is not as straightforward as the previous one, so @klihub please take a look. I'm not sure replacing GetRegistry with GetDefaultCache is correct approach.

It should be the correct approach. I'll take a closer look on Monday to see if I spot anything. But one thing I already noticed will need updating is our godoc in pkg/cdi/doc.go.

[bart0sh]

@klihub

But one thing I already noticed will need updating is our godoc in pkg/cdi/doc.go.

Thank you for pointing this out! I've updated the docs and code comments.

[bart0sh]

@elezar @klihub Can you review this PR, please?

[elezar]

Thanks @bart0sh.

I have some comments regarding docs. I also think that when it makes sense to do so, we should rather instantiate a cache instance explicitly instead of relying on the (global) default cache. Especially in cases where we are configuring the spec directories.

[bart0sh]

@elezar @klihub All review comments should be addressed now, please take a look again, thanks!

[klihub]

@bart0sh I have two very small nitpicks about help and info/error message consistency wrt. cache vs. Cache in messages. The original code was apparently inconsistent in this regard (no wonder, knowing the author), but this PR is already very close to fixing that with two exceptions.

Otherwise LGTM. Not a showstopper though, hence the approval.

[elezar]

I made some changes to the whitespace in doc.go.

Looks good otherwise.