Skip to content

Commit

Permalink
[Lens] Fix gauge responsive overflow and test unskip (elastic#202323)
Browse files Browse the repository at this point in the history
## Summary

Fixing the missing overflow in Major Arc/Circle gauge.
Unskipped tests.

close elastic#193548
fix elastic#193946
close elastic#202174
relates to elastic/kibana-operations#199
  • Loading branch information
markov00 authored Dec 2, 2024
1 parent 4eaaf76 commit 526ef51
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ export function WorkspacePanelWrapper({
flexGrow: 0,
height: '100%',
width: '100%',
overflow: 'auto',
...visDimensionsCSS,
}}
>
Expand Down
6 changes: 2 additions & 4 deletions x-pack/test/functional/apps/lens/group6/workspace_size.ts
Original file line number Diff line number Diff line change
Expand Up @@ -267,15 +267,13 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await assertWorkspaceDimensions('600px', '375px');
});

// Fails in chrome 128+: https://github.com/elastic/kibana-operations/issues/199
it.skip('gauge size (absolute pixels) - major arc', async () => {
it('gauge size (absolute pixels) - major arc', async () => {
await lens.openVisualOptions();
await lens.setGaugeShape('Major arc');
await assertWorkspaceDimensions('600px', '430px');
});

// Fails in chrome 129+: https://github.com/elastic/kibana-operations/issues/199
it.skip('gauge size (absolute pixels) - circle', async () => {
it('gauge size (absolute pixels) - circle', async () => {
await lens.openVisualOptions();
await lens.setGaugeShape('Circle');
await assertWorkspaceDimensions('600px', '430px');
Expand Down

0 comments on commit 526ef51

Please sign in to comment.