Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 122 #526

Merged
merged 28 commits into from
Oct 8, 2024
Merged

Version 122 #526

merged 28 commits into from
Oct 8, 2024

Conversation

Paulocracy
Copy link
Member

No description provided.

@Paulocracy Paulocracy self-assigned this Sep 26, 2024
@axelvonkamp
Copy link
Member

Is it necessary to always install openjdk in the installer scripts? The setup.py of efmtool_link should install a JDK if needed. At least for the CI tests it appears to work.

@Paulocracy
Copy link
Member Author

At least on systems without Java it is necessary, the efmtool_link requirements don't seem to suffice. Some check whether or not a correct JDK version could also work to prevent unneccessary JDK installations, although I'm not sure if there's a robust cross-platform way to do it.

@axelvonkamp
Copy link
Member

I just tried the Windows installer. It works but at the beginning I see warning messages that commercial Anaconda channels are being used. I am not sure whether they have actually been used, is it safe to ignore these warnings?

@Paulocracy
Copy link
Member Author

Yes you can see the warning if your global Anaconda config (which micromamba seems to use if there is one) still includes the default channel, you can remove it with conda config --remove channels defaults. In any case, with the -c conda-forge argument in the bat's mamba command, I think that the default channel is not used anywhere.

axelvonkamp
axelvonkamp previously approved these changes Sep 30, 2024
Copy link
Member

@axelvonkamp axelvonkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Paulocracy
Copy link
Member Author

Some links weren't displayed correctly, and I added conda-forge and openjdk to the conda instructions to prevent licensing problems and Java errors for the conda users

@Paulocracy Paulocracy merged commit 299e08b into master Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants