Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccnl-riot: port to new network interface API #142

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

miri64
Copy link
Collaborator

@miri64 miri64 commented Nov 28, 2017

With RIOT-OS/RIOT#7925, RIOT's network interface API was changed. This switches CCN-lite over to that new API.

@@ -203,7 +203,7 @@ int
ccnl_open_netif(kernel_pid_t if_pid, gnrc_nettype_t netreg_type)
{
assert(pid_is_valid(if_pid));
if (!gnrc_netif_exist(if_pid)) {
if (gnrc_netif_get_by_pid(if_pid) != NULL) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

== NULL !

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend the fix. ACK once provided.

@cgundogan cgundogan self-assigned this Nov 28, 2017
@blacksheeep blacksheeep merged commit f5db9ab into cn-uofbasel:master Nov 28, 2017
@miri64
Copy link
Collaborator Author

miri64 commented Nov 28, 2017

Please amend the fix. ACK once provided.

Uhm... Didn't get the chance...

@miri64 miri64 deleted the riot/api/new-netif branch November 28, 2017 11:16
@miri64
Copy link
Collaborator Author

miri64 commented Nov 28, 2017

Alright, saw that @blacksheeep added a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants