v2.0.0-beta.2 #741
Merged
v2.0.0-beta.2 #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update eslint to the latest version 🚀
Update babel-eslint to the latest version 🚀
…0 add formatter example
Update eslint to the latest version 🚀
Update grunt-contrib-uglify to the latest version 🚀
move `World Cities` to be lowest layer
Fix dynamic layer identifies for sublayer id 0
Update grunt-newer to the latest version 🚀
Update grunt-contrib-clean to the latest version 🚀
Update grunt-contrib-cssmin to the latest version 🚀
Update grunt-contrib-uglify to the latest version 🚀
Add initial support for "group" layers provided by @carrbrpoa
Add OSM layer in layerControl widget Remove `label` layer type since it has been deprecated by Esri.
Should this be the default or optional?
Feature/mobile sidebar
Update to Esri JS API upcoming version 3.21
this allows support for lazy-load of floating widgets. also allows re-usability for other widgets.. add support for iconClass for Floating widgets.
…ePane.css rearrange some styles in cmv-theme-overrides.css improved button css in cmv-theme-overrides.css for flat theme.
…bar. switch configuration option from `loadOnOpen: false/true` to `preload: true/false`.
Don't load a titlePane/floating/mobile sidebar widget until the parent widget is opened.
…open due to delayed startup
Remove `lang.clone` config from widget loader
update travis secure api key to known working key.
bump the version number for release.
…cmv-app into fix/StreetView-parentWidget
Trigger streetview 'layoutChange'
|
do we want to fix the code climate stuff? a lot of it is just css complaints |
|
Not wanting to fix those for this beta release. What I've been wanting to do is add a One specific example is to tell CC to ignore the themes folder. We should also consider removing the dboostrap theme completely. Not this time though. Continuing to ignore these (for now) is my opinion. Let me know if you feel differently. |
|
I just "Approved" the PR on the Code Climate side. We can circle back and fix them now (if desired) or later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will tag this release after merge into master branch.