Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and enable G2P code #39

Merged
merged 8 commits into from
Aug 3, 2022
Merged

Update and enable G2P code #39

merged 8 commits into from
Aug 3, 2022

Conversation

dhdaines
Copy link
Contributor

@dhdaines dhdaines commented Aug 2, 2022

This is your brain on C++, kids.

It will break in even more interesting ways if you try to compile it with the latest OpenFST, but at least this gets us up to date with what's currently in Ubuntu (and Debian, I believe), i.e. OpenFST 1.6.3 and OpenGRM NGram 1.3.2.

@dhdaines dhdaines requested a review from lenzo-ka August 2, 2022 17:55
@dhdaines dhdaines changed the title fix: senseless and gratuitous OpenFST API breakage Update and enable G2P code Aug 2, 2022
@dhdaines
Copy link
Contributor Author

dhdaines commented Aug 3, 2022

Seems to actually work now, for some definition of "working". The problems encountered don't exactly inspire confidence.

This gives us a completely GPL-free setup for training LibriSpeech, should we so desire that - I personally don't care, but maybe some do.

@dhdaines dhdaines merged commit c46fc9b into master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant