joe-work-2024-8-12 #1801
Merged
joe-work-2024-8-12 #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary parameters and configurations across several search classes including `Fci`, `SpFci`, and `LvLite`. This cleanup improves code readability and maintainability by eliminating unused functionality.
Eliminated the `ABLATION_LEAVE_OUT_FINAL_ORIENTATION` parameter as it is no longer used, simplifying the `SpFci` algorithm setup. Added logging to mark the number of available processors during parallel execution in `MarkovCheck`, enhancing debugging capabilities.
Refactored FCI search algorithms (Fci, SvarFci, SpFci, GraspFci) to manage unshielded triples for rule R0 orientation. Added repairFaultyPag method to correct faulty PAGs using unshielded triples, inducing paths, and final orientations. Updated HTML documentation to reflect new parameter descriptions and default values.
Added boolean flags and configuration to enable discriminating path tail and collider rules in FCI-related classes. This allows for more detailed control over the rule sets and improves the flexibility of the search algorithms.
Added methods to set complete rule set usage and maximum path length in FciOrient configuration. Updated TsDagToPag and Fci classes to integrate these new settings, improving the customization and flexibility of the algorithm's behavior.
Enhanced the `repairFaultyPag` method with a new `checkCyclicity` parameter to optionally check for directed cycles. Updated all relevant instances across different classes to accommodate this new parameter.
|
Just some minor fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.