Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node replacement issue for estimated graph for both local and global graph #1790

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

vbcwonderland
Copy link
Collaborator

Local graph is doing node replacement in local graph method level. This is also how we do it for local graph confusion.
Global graph node replacement should be done in whole graph level. This is also how we do it for Adj confusion and Arrowhead confusion.

@vbcwonderland vbcwonderland requested a review from jdramsey June 26, 2024 19:27
Copy link
Collaborator

@jdramsey jdramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@jdramsey jdramsey merged commit cfbf6df into development Jun 26, 2024
@jdramsey jdramsey deleted the vbc-2024-06-26 branch June 26, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants