Several fixes, updates. #1699
Several fixes, updates. #1699
Conversation
…X in SimpleDataLoader.
… to inline the uses of these methods at some point. Some stuff from the Changed class I put in the Utils in Tetrad-FX instead.
…plot. This does not work for regressions though.
…square otherwise.
Inlined GraphTransform methods in GraphSearchUtils.
…lues, or undefined score bumps are encountered. These should be handled by the calling algorithm.
…ependence facts to check for the all-subsets case.
…ependence facts to check for the all-subsets case.
|
deleting required edges appears to be bugged, they reappear after deleting them if you check/uncheck some of the checkboxes |
…uired edges in the interface, and toggle show explicitly required only, the edges reappear.
|
@bja43 Can you try it now? |
…uired edges in the interface, and toggle show explicitly required only, the edges reappear.
…ed edges could be oriented against knowledge. Also, putting CFCI back in the interface.
…e forbidden edges iterator was wrong.
…e forbidden edges iterator was wrong.
…e forbidden edges iterator was wrong.
…e forbidden edges iterator was wrong.
|
The show forbidden by tiers checkbox does not appear to do anything. I put in some tiered knowledge (including forbid within tier knowledge) after which checking the box in question did not do anything. Also, I was able add an explicitly required edge that conflicted with the tiered knowledge that I specified without any sort of error being thrown. |
|
It also looks like you can require edges that form a two-cycle (not sure if this should be allowed since some Tetrad algorithm can indeed learn two cycles.) I am also seeing the same issues that I mentioned earlier for tiers, but for knowledge groups. |
|
I'm going to go ahead and merge this so I can do the release. |
Several fixes--see commits. Will make a list.