Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final merge for 7.1.3 #1443

Merged
merged 6 commits into from
Jan 15, 2023
Merged

Final merge for 7.1.3 #1443

merged 6 commits into from
Jan 15, 2023

Conversation

jdramsey
Copy link
Collaborator

Final changes to merge into development for 7.1.3:

  • Fixed a few discrepancies from the last merge.

  • Fixed loading of text format graph files with bootstrapping information

  • Added menu items ot the Graph box File menu for saving and loading Tetrad graphs in PCALG format.

@jdramsey jdramsey requested a review from kvb2univpitt January 15, 2023 09:36
@jdramsey
Copy link
Collaborator Author

To test bootstrapping txt loading, run GFCI with bootstrapping, save the graph out as txt, then load it as txt in a different graph box. First of all, it should load now, and the edge probability table should be the same as the one saved out.

To test the PCALG format saving and loading, save the above graph out as PCALG, then load it as PCALG. You should get the same graph back. (PCALG format doesn't save bootstrapping information.)

@jdramsey jdramsey requested a review from bja43 January 15, 2023 17:02
@jdramsey
Copy link
Collaborator Author

Also, marking of latents in text graph format had been implemented. If you make a graph with latents, save it out in the text format, and load the graph in a different box, the latents should correct.

@jdramsey
Copy link
Collaborator Author

jdramsey commented Jan 15, 2023

Also, there is a menu item in the Graph box that lets you mark a graph as a PAG. If you do this, the PAG coloring will be applied. (You can also take away the PAG designation, in which case the PAG coloring will be turned off.)

@bja43
Copy link
Collaborator

bja43 commented Jan 15, 2023

The parameter description for resampling size is misleading. It says the the min is 0.1, implying that it should accept a range between 0.1 and 1, where 0.1 is 10% and 1 is 100%. However, the default value is 90, which I assume is 90% and if you give it any value less than 1, the parameter appears to be ignored and the last valid value is used instead.

FIXED

@bja43
Copy link
Collaborator

bja43 commented Jan 15, 2023

  • Saving and loading of graphs resulting from bootstrapped searches seems to be functioning property.
  • Saving and loading PCALG graphs seems to be functioning properly.
  • Saving and loading DAGs with latents seems to be functioning properly.

Cool -JR

@bja43
Copy link
Collaborator

bja43 commented Jan 15, 2023

  • Non-maximal graphs can be marked as PAGs without an error or warning being thrown.
  • Non-ancestral graphs can be marked as PAGs without an error or warning being thrown.
  • When a graph is marked as a PAG, clicking an edge changes it's coloring. For example, if you click on the head of a bold arrow, then it becomes a non-bolded dashed arrow. If you unmark as PAG and then remark as PAG, the edge is once again bolded.
  • As a followup to the last bullet point, if you modify the graph by clicking an edge, then the coloring does not update to incorporate the change to the graph.

FIXED SOME OF THIS STUFF, SOME WILL HAVE TO WAIT TILL THE NEXT REVISION... -JR

@jdramsey
Copy link
Collaborator Author

jdramsey commented Jan 15, 2023

Will fix the errors. As for thrown an exception of non-PAG, one item on my to-do list for the next version is a test for legal PAG, and I can fix that problem then.

But I will fix the parameter range. FIXED

I can easily re-apply PAG coloring after each change, will do that.

  • If you add new edges now the PAG coloring updates, but I can't get it to update for all edge reorientations yet... will make that an issue to work on for the next release.

... Actually let me try to fix that stuff now; I have a few minutes...

@bja43 bja43 closed this Jan 15, 2023
@bja43 bja43 reopened this Jan 15, 2023
Copy link
Collaborator

@bja43 bja43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jdramsey jdramsey merged commit 4ea7027 into development Jan 15, 2023
@jdramsey jdramsey deleted the final_7_1_3_merge branch January 15, 2023 23:48
}
}

if (probability > 0.0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdramsey Why is the edge probability printout code removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants