-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final merge for 7.1.3 #1443
Final merge for 7.1.3 #1443
Conversation
…aving/loading of Tetrad graphs in PCALG format.
…aving/loading of Tetrad graphs in PCALG format.
… future release).
To test bootstrapping txt loading, run GFCI with bootstrapping, save the graph out as txt, then load it as txt in a different graph box. First of all, it should load now, and the edge probability table should be the same as the one saved out. To test the PCALG format saving and loading, save the above graph out as PCALG, then load it as PCALG. You should get the same graph back. (PCALG format doesn't save bootstrapping information.) |
Also, marking of latents in text graph format had been implemented. If you make a graph with latents, save it out in the text format, and load the graph in a different box, the latents should correct. |
Also, there is a menu item in the Graph box that lets you mark a graph as a PAG. If you do this, the PAG coloring will be applied. (You can also take away the PAG designation, in which case the PAG coloring will be turned off.) |
The parameter description for resampling size is misleading. It says the the min is 0.1, implying that it should accept a range between 0.1 and 1, where 0.1 is 10% and 1 is 100%. However, the default value is 90, which I assume is 90% and if you give it any value less than 1, the parameter appears to be ignored and the last valid value is used instead. FIXED |
Cool -JR |
FIXED SOME OF THIS STUFF, SOME WILL HAVE TO WAIT TILL THE NEXT REVISION... -JR |
Will fix the errors. As for thrown an exception of non-PAG, one item on my to-do list for the next version is a test for legal PAG, and I can fix that problem then. But I will fix the parameter range. FIXED I can easily re-apply PAG coloring after each change, will do that.
... Actually let me try to fix that stuff now; I have a few minutes... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
} | ||
} | ||
|
||
if (probability > 0.0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdramsey Why is the edge probability printout code removed?
Final changes to merge into development for 7.1.3:
Fixed a few discrepancies from the last merge.
Fixed loading of text format graph files with bootstrapping information
Added menu items ot the Graph box File menu for saving and loading Tetrad graphs in PCALG format.