Merge pull request #1785 from cmu-phil/vbc-2024-06-14

getAndersonDarlingTestAcceptsRejectsNodes Typo fix
cmu-phil · Jun 17, 2024 · c3e08d2 · c3e08d2
2 parents 6aa0340 + 54d2aa6
commit c3e08d2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/tetrad-lib/src/main/java/edu/cmu/tetrad/search/MarkovCheck.java b/tetrad-lib/src/main/java/edu/cmu/tetrad/search/MarkovCheck.java
@@ -413,27 +413,27 @@ public List<List<Node>> getAndersonDarlingTestAcceptsRejectsNodesForAllNodesPlot
                     rejects_AdjP_ADTestP.add(Arrays.asList(ap, ADTestPValue));
                 }
                 if (!Double.isNaN(ar)) {
-                    rejects_AdjR_ADTestP.add(Arrays.asList(ap, ADTestPValue));
+                    rejects_AdjR_ADTestP.add(Arrays.asList(ar, ADTestPValue));
                 }
                 if (!Double.isNaN(ahp)) {
-                    rejects_AHP_ADTestP.add(Arrays.asList(ap, ADTestPValue));
+                    rejects_AHP_ADTestP.add(Arrays.asList(ahp, ADTestPValue));
                 }
                 if (!Double.isNaN(ahr)) {
-                    rejects_AHR_ADTestP.add(Arrays.asList(ap, ADTestPValue));
+                    rejects_AHR_ADTestP.add(Arrays.asList(ahr, ADTestPValue));
                 }
             } else {
                 accepts.add(x);
                 if (!Double.isNaN(ap)) {
                     accepts_AdjP_ADTestP.add(Arrays.asList(ap, ADTestPValue));
                 }
                 if (!Double.isNaN(ar)) {
-                    accepts_AdjR_ADTestP.add(Arrays.asList(ap, ADTestPValue));
+                    accepts_AdjR_ADTestP.add(Arrays.asList(ar, ADTestPValue));
                 }
                 if (!Double.isNaN(ahp)) {
-                    accepts_AHP_ADTestP.add(Arrays.asList(ap, ADTestPValue));
+                    accepts_AHP_ADTestP.add(Arrays.asList(ahp, ADTestPValue));
                 }
                 if (!Double.isNaN(ahr)) {
-                    accepts_AHR_ADTestP.add(Arrays.asList(ap, ADTestPValue));
+                    accepts_AHR_ADTestP.add(Arrays.asList(ahr, ADTestPValue));
                 }
             }
         }

diff --git a/tetrad-lib/src/test/java/edu/cmu/tetrad/test/TestCheckMarkov.java b/tetrad-lib/src/test/java/edu/cmu/tetrad/test/TestCheckMarkov.java
@@ -113,9 +113,8 @@ public void test2() {
 
     @Test
     public void testGaussianDAGPrecisionRecallForLocalOnMarkovBlanket() {
-//         Graph trueGraph = RandomGraph.randomDag(10, 0, 10, 100, 100, 100, false);
 //       TODO VBC: Also check different dense graph.
-        Graph trueGraph = RandomGraph.randomDag(20, 0, 40, 100, 100, 100, false);
+        Graph trueGraph = RandomGraph.randomDag(20, 0, 80, 100, 100, 100, false);
         System.out.println("Test True Graph: " + trueGraph);
         System.out.println("Test True Graph size: " + trueGraph.getNodes().size());
 
@@ -409,7 +408,7 @@ public void testNonGaussianCPDAGPrecisionRecallForLocalOnParents() {
 
     @Test
     public void testGaussianDAGPrecisionRecallForLocalOnMarkovBlanket2() {
-        Graph trueGraph = RandomGraph.randomDag(10, 0, 10, 100, 100, 100, false);
+        Graph trueGraph = RandomGraph.randomDag(20, 0, 80, 100, 100, 100, false);
         System.out.println("Test True Graph: " + trueGraph);
         System.out.println("Test True Graph size: " + trueGraph.getNodes().size());