improve epi df doc #103
Merged
improve epi df doc #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookslogan
reviewed
Jun 20, 2022
brookslogan
reviewed
Jun 23, 2022
brookslogan
reviewed
Jun 23, 2022
brookslogan
reviewed
Jun 23, 2022
brookslogan
reviewed
Jun 23, 2022
brookslogan
reviewed
Jun 23, 2022
brookslogan
reviewed
Jun 23, 2022
brookslogan
reviewed
Jun 23, 2022
brookslogan
reviewed
Jun 23, 2022
brookslogan
reviewed
Jun 23, 2022
brookslogan
reviewed
Jun 23, 2022
brookslogan
requested changes
Jun 23, 2022
There was a problem hiding this comment.
Nice examples! We may want to borrow these when constructing any tests for behavior regarding other_keys. I have a some minor comments/requests + we should check on / copy over the appropriate data attribution to this vignette + a couple things that should be filed as separate issues if not addressed here.
|
@brookslogan I think I've addressed all the comments. Let me know if anything else should be changed, otherwise we can probably merge this? Thanks! |
brookslogan
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93.
One example file was created and stored inman/rmd/epi-df-example.Rmd. The file was referred to in the main epiprocess vignette and also in theas_epi_df()example section.#' @includeRmd man/rmd/<some-name>.Rmd examplesthrows errors so the examples are added to the main vignette and the roxygen separately. The documentation states: