Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix tests for merging #668 #669

Merged
merged 1 commit into from
Aug 5, 2021
Merged

fix: fix tests for merging #668 #669

merged 1 commit into from
Aug 5, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Aug 5, 2021 •
edited
Loading

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

I was to eager to click the merge button of #668

@sgratzl sgratzl added the bug label Aug 5, 2021
@sgratzl sgratzl requested a review from krivard August 5, 2021 18:03
@sgratzl sgratzl self-assigned this Aug 5, 2021
krivard
krivard approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgratzl sgratzl merged commit 6f8cee8 into dev Aug 5, 2021
@sgratzl sgratzl deleted the sgratzl/weekparser branch August 5, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees

@sgratzl sgratzl

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgratzl @krivard