Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-symptoms documentation with results of 2023 summer dip fix #1587

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jan 27, 2025

Summary:

Dip was not fixable in any meaningful way, so move the dip warning to "Limitations" section and add a small high-level warning to the intro paragraph.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@nmdefries nmdefries requested a review from aysim319 January 27, 2025 22:10
@nmdefries nmdefries merged commit 8cfb191 into dev Jan 28, 2025
8 checks passed
@nmdefries nmdefries deleted the ndefries/gs-dip-2023 branch January 28, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants