Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention of secondary signals from NSSP docs #1573

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Remove mention of secondary signals from NSSP docs #1573

merged 2 commits into from
Jan 23, 2025

Conversation

minhkhul
Copy link
Contributor

@minhkhul minhkhul commented Jan 21, 2025 •
edited
Loading

For context, check covidcast-indicators repo issue #2099

Summary:

Remove all mention of secondary source from nssp docs.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@minhkhul minhkhul requested a review from melange396 January 22, 2025 18:01
melange396
melange396 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This essentially reverts #1558

@melange396 melange396 merged commit 7b33f6a into dev Jan 23, 2025
7 of 8 checks passed
@melange396 melange396 deleted the docs-remove-secondary-nssp branch January 23, 2025 18:31
@melange396 melange396 mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minhkhul @melange396