Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding docs #1570

Merged
merged 14 commits into from
Jan 13, 2025
Merged

adding docs #1570

merged 14 commits into from
Jan 13, 2025

Conversation

aysim319
Copy link
Contributor

@aysim319 aysim319 commented Jan 6, 2025

add docs for NHSN data

Addresses #1569

@aysim319 aysim319 requested a review from nmdefries January 6, 2025 16:08
@aysim319
Copy link
Contributor Author

aysim319 commented Jan 6, 2025

also noticed that NSSP isn't mentioned in the https://cmu-delphi.github.io/delphi-epidata/api/covidcast_signals.html at the dashboad signals page when is it in the public dashboard.

@aysim319 aysim319 requested a review from dsweber2 January 6, 2025 16:12
docs/api/covidcast-signals/nhsn.md Outdated Show resolved Hide resolved
docs/api/covidcast-signals/nhsn.md Outdated Show resolved Hide resolved
docs/api/covidcast-signals/nhsn.md Show resolved Hide resolved
@nmdefries
Copy link
Contributor

nmdefries commented Jan 6, 2025

Is "reporting dates" what we're calling "time values" now? I think someone was working on defining new official terminology

Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting more detail in some sections.

docs/api/covidcast-signals/nhsn.md Outdated Show resolved Hide resolved
docs/api/covidcast-signals/nhsn.md Outdated Show resolved Hide resolved
docs/api/covidcast-signals/nhsn.md Outdated Show resolved Hide resolved
docs/api/covidcast-signals/nhsn.md Outdated Show resolved Hide resolved
docs/api/covidcast-signals/nhsn.md Outdated Show resolved Hide resolved
docs/api/covidcast-signals/nhsn.md Outdated Show resolved Hide resolved
docs/api/covidcast-signals/nhsn.md Show resolved Hide resolved
docs/api/covidcast-signals/nhsn.md Show resolved Hide resolved
@aysim319
Copy link
Contributor Author

aysim319 commented Jan 7, 2025

Is "reporting dates" what we're calling "time values" now? I think someone was working on defining new official terminology

I've been using the column names that's in the api for consistency sake, but if reporting dates are the main vocab i can change it

@aysim319
Copy link
Contributor Author

aysim319 commented Jan 7, 2025

@nmdefries from the comment that I couldn't make a reply for:

Total number of patients hospitalized with confirmed COVID-19 over the entire week (Sunday – Saturday). This is preliminary data that is <...whatever that means>. Only includes hospitalizations reported before Wednesday of the following week.
Make sure to clarify what "preliminary data" means -- my initial point of confusion is that the prelim and non-prelim data seem to be reported at the same time and for the same week. So what's the difference?

the preliminary comes few days earlier, both will report the same latest reporting week, but compared to the main one which you would have to wait a full weeks (friday-saturday) to pass, the preliminary data comes wednesday-ish.

preliminary (*last updated jan 2nd)
Screenshot 2025-01-07 at 11 54 46 AM

main (*last updated jan 3rd)
Screenshot 2025-01-07 at 11 54 36 AM

*I believe that fluview mentioned that for the week of the new years the reporting updates would be delayed

@nmdefries
Copy link
Contributor

Is "reporting dates" what we're calling "time values" now? I think someone was working on defining new official terminology

In my edit, I switched all mentions of "reporting date" to "reference date" for clarity. I think "reporting date" sounds like it means "report date"/"issue date".

@nmdefries nmdefries self-requested a review January 10, 2025 21:47
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, except for the failing test.

@aysim319 aysim319 merged commit 0924b85 into dev Jan 13, 2025
7 of 8 checks passed
@aysim319 aysim319 deleted the 1569-add-nhsn-docs branch January 13, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants