-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nssp patching code #2000
base: main
Are you sure you want to change the base?
nssp patching code #2000
Conversation
Note: About custom_run flag, non-patch custom run doesn't really exist in nssp like it does in google-symptoms due to the differences in how the two sources handle revision data and how we grab those data. We'll keep the flag in nssp still to maintain consistency and to disambiguate params.json. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue with generating duplicate data, and a couple clarifying questions.
Description
Add patching feature to nssp.
One detail that set this implementation apart from most of our other indicators is that nssp data comes in our db as weekly form instead of daily.
Basically, all weekly data coming in to our db has the
issue_date
column always marked as the first date of the epiweek that the reporting date falls into, rather than the reporting date itself. For example, I query nssp data from our api that was just put into db on July 5th 2024 and got something like this:Note the issue is
2024-06-30
despite this data coming in on July 5th. It's because2024-06-30
is the start date of epiweek202427
, so any data coming in that week will be marked under that issue date.Furthermore, the reason why we use this directory format is because of this
batch_issue_format
implementation in acquisition, which demands folder format to beissue_yyyymmdd
including for patches of weekly data.Fixes