Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hhs and chng from sircal #1971

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

minhkhul
Copy link
Contributor

@minhkhul minhkhul commented Jun 5, 2024

Description

HHS and Chng are no longer active. So we're removing these items from sircal daily checks/complaints.

@minhkhul minhkhul requested a review from nmdefries June 5, 2024 22:13
@melange396 melange396 mentioned this pull request Jun 6, 2024
@nmdefries
Copy link
Contributor

HHS changes look fine, but I'm not sure we should be turning off alerts for CHNG. We're still expecting it to come back online at some point, right? Maybe it's safer (to keep us from forgetting about it) to keep the alerts going in Slack -- what do you think?

@melange396
Copy link
Contributor

@nmdefries Fair point, but it is not clear right now when CHNG will come back nor what it will look like when it does. We also have the "ChangeHealthcare FTP Checker" in the same slack channel that should let us know if our access is restored, and the SirCAL alert just adds more noise... Maybe just comment out the CHNG stuff for the time being?

Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Comment on lines -15 to -19
"chng": {
"max_age": 6,
"maintainers": ["U01AP8GSWG3","U01069KCRS7"],
"retired-signals": ["7dav_outpatient_covid","7dav_inpatient_covid"]
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (optional): Maybe just comment out the CHNG stuff for the time being instead of removing it entirely, so it's easy to find/reference later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So til you cannot comment in json files.

@minhkhul minhkhul merged commit 84d0597 into main Jun 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants