-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove hhs and chng from sircal #1971
Conversation
HHS changes look fine, but I'm not sure we should be turning off alerts for CHNG. We're still expecting it to come back online at some point, right? Maybe it's safer (to keep us from forgetting about it) to keep the alerts going in Slack -- what do you think? |
@nmdefries Fair point, but it is not clear right now when CHNG will come back nor what it will look like when it does. We also have the "ChangeHealthcare FTP Checker" in the same slack channel that should let us know if our access is restored, and the SirCAL alert just adds more noise... Maybe just comment out the CHNG stuff for the time being? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
"chng": { | ||
"max_age": 6, | ||
"maintainers": ["U01AP8GSWG3","U01069KCRS7"], | ||
"retired-signals": ["7dav_outpatient_covid","7dav_inpatient_covid"] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (optional): Maybe just comment out the CHNG stuff for the time being instead of removing it entirely, so it's easy to find/reference later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So til you cannot comment in json files.
Description
HHS and Chng are no longer active. So we're removing these items from sircal daily checks/complaints.