Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nssp staging #1950

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Nssp staging #1950

merged 3 commits into from
Apr 25, 2024

Conversation

minhkhul
Copy link
Contributor

Description

These are configurations to help nssp run in staging, not nssp indicator itself. This should not be merged until nssp indicator is already merged.

Changelog

  • add ansible config for params.json used in staging
  • add nssp to indicator list in jenkinsfile.
  • apart from changes here, also created nssp dir in /common/covidcast/receiving/ on staging for .csv files to live in along with other indicators.

@minhkhul minhkhul requested review from dsweber2 and removed request for dsweber2 March 20, 2024 18:18
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name for the token gets a bit awkward, but its not really a big deal

"wip_signal": true,
"export_start_date": "2020-02-01",
"static_file_dir": "./static",
"socrata_token": "{{ nwss_wastewater_token }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to rename nwss_wastewater_token if we reuse it elsewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. changed.

Copy link
Contributor Author

@minhkhul minhkhul Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsweber2 Wait, I want to confirm that nssp uses the same cdc socrata token like with nchs and nwss correct?

@minhkhul minhkhul mentioned this pull request Apr 22, 2024
@minhkhul minhkhul changed the base branch from main to nssp April 25, 2024 06:08
@minhkhul minhkhul merged commit b4ec831 into nssp Apr 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants