window aggregation -> window function; change formatter #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicola115 <[email protected]>
Signed-off-by: Nicola115 <[email protected]>
Signed-off-by: Nicola115 <[email protected]>
skyzh
approved these changes
Oct 25, 2023
src/binder/bind_select.cpp
Outdated
| @@ -564,7 +564,7 @@ auto Binder::BindFuncCall(duckdb_libpgquery::PGFuncCall *root) -> std::unique_pt | |||
| } | |||
|
|
|||
| if (function_name == "min" || function_name == "max" || function_name == "first" || function_name == "last" || | |||
| function_name == "sum" || function_name == "count") { | |||
| function_name == "sum" || function_name == "count" || function_name == "rank") { | |||
There was a problem hiding this comment.
I think we still need to have ROW_NUMBER here, but rewriting it to count(1) somewhere in planner?
There was a problem hiding this comment.
I changed it to WindowFunctionExecutor because I think rank and row_number are not aggregations and in postgres docs, it is also named as window function.
About Row_number, I'll add the row_number function and change it to count(1) in planner.
Signed-off-by: Nicola115 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT PUSH PROJECT SOLUTIONS PUBLICLY.
And especially do NOT open pull requests with project solutions!
Please be considerate of this free educational resource.