Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dummy labview #16

Merged
merged 10 commits into from
Aug 30, 2023
Merged

Feature/dummy labview #16

merged 10 commits into from
Aug 30, 2023

Conversation

cbernet
Copy link
Contributor

@cbernet cbernet commented Jul 18, 2023

  • web server can now be deployed in the stack as a docker container
  • script that can inject dummy labview data
  • migration to pyproject.toml
  • improved documentation

@cbernet cbernet requested review from cdozen and ArnabPurohit July 18, 2023 12:11
@cbernet
Copy link
Contributor Author

cbernet commented Jul 18, 2023

@ArnabPurohit can you please review this PR whenever possible ? I'm waiting for your review to merge. Don't hesitate to ask questions as PR comments

@cbernet cbernet removed the request for review from cdozen July 18, 2023 12:13
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #16 (995e7ec) into main (aa93d0c) will increase coverage by 0.71%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   96.69%   97.41%   +0.71%     
==========================================
  Files           7        8       +1     
  Lines         212      232      +20     
==========================================
+ Hits          205      226      +21     
+ Misses          7        6       -1     
Flag Coverage Δ
unittests 97.41% <100.00%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tracker_dcs_web/mqtt.py 100.00% <100.00%> (+11.11%) ⬆️
tracker_dcs_web/web_server/app.py 95.34% <100.00%> (+0.34%) ⬆️
tracker_dcs_web/web_server/data/measurements.py 95.00% <100.00%> (+0.35%) ⬆️
tracker_dcs_web/web_server/data/metadata.py 97.95% <100.00%> (+0.08%) ⬆️
unittests/fixtures.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cbernet
Copy link
Contributor Author

cbernet commented Jul 21, 2023

@ArnabPurohit still on it ?

@ArnabPurohit
Copy link
Member

@ArnabPurohit still on it ?

Yes

@ArnabPurohit
Copy link
Member

I have reviewed the PR and tested it in my private area. It works as intended. I have no other questions than above.

@ArnabPurohit ArnabPurohit reopened this Aug 30, 2023
@cbernet cbernet merged commit 6c4c852 into main Aug 30, 2023
@cbernet cbernet deleted the feature/dummy_labview branch August 30, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants