Tau RECO on MiniAOD: A fix and addressed review comments #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbluj @swozniewski I'm inclined to merge this fairly soon since the changes are relatively trivial, but please let me know if you want to have a deeper look. |
|
I checked and it is fine for me, please go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the merging of the charged hadrons used as input in the tau reconstruction with neutrals, where the deltaR was calculated with respect to the tau charged hadron and not the PF charged hadron, which would make a difference in a very rare case where two neutrals would be merged and the deltaR could be different after merging the first.
Also addresses two minor review comments.