-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boosted Tau Production Changes for Ultra Legacy #87
base: master
Are you sure you want to change the base?
Boosted Tau Production Changes for Ultra Legacy #87
Conversation
Conflicts: Production/python/sampleConfig.py
…TauMLTools into BoostedTauULProductionCommits
…duction code. Removes the redundant ED filter infrastructure, and changes the configuration to make useBoostedTauFilter an option given to TauTupleProducer. This option should now remove all non boosted tau type tau jets
Ntuples otherwise seem to get empty MVA evaluations
from TauMLTools.Production.runTauIdMVA import runTauID | ||
updatedBoostedTauName = "slimmedBoostedTausNewID" | ||
runTauID(process, outputTauCollection=updatedBoostedTauName, inputTauCollection="slimmedTausBoosted", | ||
toKeep = [ "2017v2", "dR0p32017v2", "newDM2017v2", "deepTau2017v2p1" ]) | ||
process.boostedSequence = cms.Sequence( | ||
getattr(process, updatedBoostedTauName+'rerunMvaIsolationSequence') * | ||
getattr(process, updatedBoostedTauName) | ||
) | ||
boostedTaus_InputTag = cms.InputTag(updatedBoostedTauName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you rerun boosted tau ids for Run2 UL? It should be already included in miniAOD. At least it is the recommended way, as far as I know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running UL Ntuples without these lines, the MVA branches ended up empty (all 0), and it was causing issues with validation (I need to rerun a few ntuples now). These lines remedy the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is strange. Perhaps the name of the stored mva ID is different? I think it is worth looking at more closely because if there are some problems with boosted taus in UL miniAODs, we need to make sure that it is documented.
After some particularly circuitous commits adding some hacks and then removing them, this is the current status of the boosted tau effort UL production. The only real changes after the added and removed hacks is the introduction of some sample types and global tags, and a change to the
isRun2UL
function. For Boosted Tau convenience I have added a quick filter that can be added into the production that simply checks that there is some boosted tau in the collection before attempting to do any Ntuplization, but if this is not desirable in the main repository, it can be removed from the commit.We will be attempting to make ntuples from all 4 UL time periods under this setup.
I will open a PR for the general boosted tau changes, but that similarly needs to be cleaned up to prevent superfluous merge conflicts from distracting from genuine ones.