Runtime cxxmodules aarch64 #212

smuzaffar · 2024-10-11T08:54:56Z

Seems to be headless usage of Firefox not yet testet there

1. Fix - do not force style 8 for hist markers 2. Fix - ensure minimal hist title height 3. Fix - proper font-size handling in latex

OpenGL is required by various graf3d features that are enabled with opengl=ON, or by the Cocoa-related code that always requires it. The `opengl` build flag had an awkward double responsability: it is used to enable these OpenGL graf3d features, and also it is required to be ON when building with Cocoa because the Cocoa code depends on OpenGL. That means, if you want to build with `cocoa=ON`, you had no way to disable the graf3d features even if you don't want them. One way to disentangle this problem is to look for OpenGL also when `cocoa=ON`, independent of the `opengl` flag. This commit makes it possible to disable the OpenGL graf3d features on macOS when building with `cocoa=ON`.

The opengl flag enables the graf3d features that depend on OpenGL, and these features also depend on asimage. Therefore, the configuration should fail if `asimage` is OFF and `opengl` is ON. An alternative would have been to automatically enable `asimage` then, but `asimage=ON` is already the default. So if it's actually off, it's probably set to OFF by the user with some intention, and we better raise awareness about this inconsistency with a configuration error. Closes root-project#16250.

It was disabled in commit a67863d ("Disable modules on aarch64 due to ODR violation") in 2019. I cannot reproduce these problems on lxplus-arm, so try to turn it back on.

smuzaffar · 2024-10-11T08:55:15Z

please test for CMSSW_14_2_ROOT6_X/el8_aarch64_gcc12

cmsbuild · 2024-10-11T08:55:21Z

A new Pull Request was created by @smuzaffar for branch cms/master/df563f6c8e.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2024-10-11T08:55:21Z

cms-bot internal usage

smuzaffar · 2024-10-11T09:00:25Z

test parameters:

full_cmssw = true

smuzaffar · 2024-10-11T09:00:32Z

please test for CMSSW_14_2_ROOT6_X/el8_aarch64_gcc12

cmsbuild · 2024-10-11T13:52:03Z

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b6638/42123/summary.html
COMMIT: 3320cc2
CMSSW: CMSSW_14_2_ROOT6_X_2024-10-10-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/212/42123/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b6638/42123/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b6638/42123/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMOfflineConfigurationGotAll had ERRORS

RelVals

140.063

----- Begin Fatal Exception 11-Oct-2024 15:08:51 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing  Event run: 357735 lumi: 53 event: 87840020 stream: 0
   [1] Running path 'dqmoffline_1_step'
   [2] Prefetching for module NanoAODDQM/'nanoDQM'
   [3] Prefetching for module SimplePATTauFlatTableProducer/'boostedTauTable'
   [4] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [5] Prefetching for module PATMuonRefSelector/'finalMuons'
   [6] Prefetching for module PATMuonUserDataEmbedder/'slimmedMuonsWithUserData'
   [7] Calling method for module EvaluateMuonMVAID/'muonMVAID'
   Additional Info:
      [a] Fatal Root Error: @SUB=TClingCallFunc::make_wrapper
Failed to compile
  ==== SOURCE BEGIN ====
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wformat-security"
__attribute__((used)) __attribute__((annotate("__cling__ptrcheck(off)")))
extern "C" void __cf_365(void* obj, int nargs, void** args, void* ret)
{
   if (ret) {
      new (ret) (double) (((const reco::TrackBase*)obj)->validFraction());
      return;
   }
   else {
      (void)(((const reco::TrackBase*)obj)->validFraction());
      return;
   }
}
#pragma clang diagnostic pop
  ==== SOURCE END ====

----- End Fatal Exception -------------------------------------------------

140.043

----- Begin Fatal Exception 11-Oct-2024 15:08:51 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing  Event run: 356381 lumi: 67 event: 55871456 stream: 0
   [1] Running path 'dqmoffline_1_step'
   [2] Prefetching for module NanoAODDQM/'nanoDQM'
   [3] Prefetching for module SimplePATTauFlatTableProducer/'boostedTauTable'
   [4] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [5] Prefetching for module PATMuonRefSelector/'finalMuons'
   [6] Prefetching for module PATMuonUserDataEmbedder/'slimmedMuonsWithUserData'
   [7] Calling method for module EvaluateMuonMVAID/'muonMVAID'
   Additional Info:
      [a] Fatal Root Error: @SUB=TClingCallFunc::make_wrapper
Failed to compile
  ==== SOURCE BEGIN ====
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wformat-security"
__attribute__((used)) __attribute__((annotate("__cling__ptrcheck(off)")))
extern "C" void __cf_365(void* obj, int nargs, void** args, void* ret)
{
   if (ret) {
      new (ret) (double) (((const reco::TrackBase*)obj)->validFraction());
      return;
   }
   else {
      (void)(((const reco::TrackBase*)obj)->validFraction());
      return;
   }
}
#pragma clang diagnostic pop
  ==== SOURCE END ====

----- End Fatal Exception -------------------------------------------------

140.023

----- Begin Fatal Exception 11-Oct-2024 15:08:52 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing  Event run: 355769 lumi: 37 event: 23914185 stream: 0
   [1] Running path 'dqmoffline_1_step'
   [2] Prefetching for module NanoAODDQM/'nanoDQM'
   [3] Prefetching for module SimplePATTauFlatTableProducer/'boostedTauTable'
   [4] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [5] Prefetching for module PATMuonRefSelector/'finalMuons'
   [6] Prefetching for module PATMuonUserDataEmbedder/'slimmedMuonsWithUserData'
   [7] Calling method for module EvaluateMuonMVAID/'muonMVAID'
   Additional Info:
      [a] Fatal Root Error: @SUB=TClingCallFunc::make_wrapper
Failed to compile
  ==== SOURCE BEGIN ====
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wformat-security"
__attribute__((used)) __attribute__((annotate("__cling__ptrcheck(off)")))
extern "C" void __cf_366(void* obj, int nargs, void** args, void* ret)
{
   if (ret) {
      new (ret) (double) (((const reco::TrackBase*)obj)->validFraction());
      return;
   }
   else {
      (void)(((const reco::TrackBase*)obj)->validFraction());
      return;
   }
}
#pragma clang diagnostic pop
  ==== SOURCE END ====

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

jblomer and others added 7 commits October 9, 2024 11:14

[ntuple] support projections into leaf chains

b93dd4e

[ntuple] forbid projection across fixed-size arrays

9894de7

Disable test-stressgraphics-firefox on Mac

ffee487

Seems to be headless usage of Firefox not yet testet there

[jsroot] dev 8/10/2024

1f1638e

1. Fix - do not force style 8 for hist markers 2. Fix - ensure minimal hist title height 3. Fix - proper font-size handling in latex

[runtime_cxxmodules] Enable on AArch64

3320cc2

It was disabled in commit a67863d ("Disable modules on aarch64 due to ODR violation") in 2019. I cannot reproduce these problems on lxplus-arm, so try to turn it back on.

cmsbuild added orp-pending pending-signatures externals-pending tests-started labels Oct 11, 2024

smuzaffar mentioned this pull request Oct 11, 2024

[runtime_cxxmodules] Enable on AArch64 root-project/root#16401

Merged

cmsbuild added tests-rejected and removed tests-started labels Oct 11, 2024

smuzaffar closed this Dec 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Runtime cxxmodules aarch64 #212

Runtime cxxmodules aarch64 #212

smuzaffar commented Oct 11, 2024

smuzaffar commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

cmsbuild commented Oct 11, 2024 •

edited

Loading

smuzaffar commented Oct 11, 2024

smuzaffar commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

Runtime cxxmodules aarch64 #212

Runtime cxxmodules aarch64 #212

Conversation

smuzaffar commented Oct 11, 2024

smuzaffar commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

cmsbuild commented Oct 11, 2024 • edited Loading

smuzaffar commented Oct 11, 2024

smuzaffar commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

Unit Tests

RelVals

cmsbuild commented Oct 11, 2024 •

edited

Loading