[13_3_X] fBits read: preserve kIsOnHeap, always set kNotDeleted.

[iarspider]

Rather than reading from the file the value of kIsOnHeap, preserve the value that was calculated at object creation time (i.e. in the current execution). For example, for an embedded object (inside an object created on the heap or stack), the bit always need to be off (i.e. it can never be explicitly deleted)

[iarspider]

please test for CMSSW_13_3_X

[cmsbuild]

A new Pull Request was created by @iarspider for branch cms/v6-26-00-patches/9583d15fbe.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93d8e7/37411/summary.html
COMMIT: 7a550be
CMSSW: CMSSW_13_3_X_2024-02-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/204/37411/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 290 lines from the logs
• Reco comparison results: 136 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3364261
• DQMHistoTests: Total failures: 2392
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3361847
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

@iarspider , please open a cmsdist PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next cms/v6-26-00-patches/9583d15fbe IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)