-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13_0_X] fBits read: preserve kIsOnHeap, always set kNotDeleted. #201
Conversation
Rather than reading from the file the value of kIsOnHeap, preserve the value that was calculated at object creation time (i.e. in the current execution). For example, for an embedded object (inside an object created on the heap or stack), the bit always need to be off (i.e. it can never be explicitly deleted)
please test for CMSSW_13_0_X |
A new Pull Request was created by @iarspider for branch cms/v6-26-00-patches/5858905487. @iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48dcb7/37407/summary.html Comparison SummarySummary:
|
+externals @iarspider , I am merging it please open a cmsdist PR |
This pull request is fully signed and it will be integrated in one of the next cms/v6-26-00-patches/5858905487 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
[13_0_X] Fix ROOT backwards compatibility (cms-sw/root#201)
Rather than reading from the file the value of kIsOnHeap, preserve the value that was calculated at object creation time (i.e. in the current execution). For example, for an embedded object (inside an object created on the heap or stack), the bit always need to be off (i.e. it can never be explicitly deleted)