Backport jitlink ppc64 #188

smuzaffar · 2023-10-13T10:34:24Z

No description provided.

Forwarding data (differently) or passing trivial parameters.

... takes an additional vector for canonical arguments.

... takes a Decl and a boolean argument Final.

Now we can just inherit from InProcessMemoryManager and override the deallocate() method.

Store a reference ourselves. Also Lexer::isIdentifierBodyChar() was renamed to Lexer::isAsciiIdentifierContinueChar().

These two fields don't exist anymore in LLVM 16.

The function overload without PrintingPolicy is not available in LLVM 16, see https://reviews.llvm.org/D134813.

The GlobalDecl parameter wasn't used since quite some time.

adjustPassManager was only used for a few backends, such as AMDGPU and NVPTX, but not on the CPU architectures we care about. The DiscriminatorsPass was also removed upstream Clang, see commit llvm/llvm-project@2978d02681.

In LLVM 16, we now get ElaboratedType far more often, but they don't have all namespace qualifiers we need. This fixes the build of the RooFitCore module, but many other places are likely affected as well.

GenericLLVMIRPlatformSupport now declares atexit, which leads to a duplicate symbol error during startup and fails the transaction. Completely switch to the provided infrastructure and just override the helpers to register the functions with our Interpreter.

According to llvm/llvm-project@af27466c50, it is used to represent types pulled in with a using declaration, for example `using std::error_code; error_code x;`. This fixes the build of the ROOTTMVASofie module on macOS where this was causing `std::size_t` not be fully desugared to `unsigned long` at first to later end up with two identical classes in a list that must not have duplicates.

In LLVM 16, we get ElaboratedType's in TemplateArgument's and need to recurse into them. This fixes the handling of Double32_t in the test roottest-root-io-double32-make.

With the upgrade to LLVM 16, we again have test failures due to crashes and output ordering compared to the reference files. This reverts commit 47277df.

cmsbuild · 2023-10-13T15:41:14Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e3c07/35174/summary.html
COMMIT: 7174086
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/188/35174/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Building binary testConditionDatabase_4
Copying tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testConditionDatabase_4/testConditionDatabase_4 to productstore area:
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-12-2300/src/CondCore/CondDB/test/testConnectionPool.cpp
>> Building binary testConnectionPool
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCondFormatsRunInfo: No such file or directory
collect2: error: ld returned 1 exit status
>> Deleted: tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool
gmake: *** [tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool] Error 1
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-12-2300/src/CondCore/CondDB/test/testFrontier.cpp
>> Building binary testFrontier
Copying tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testFrontier/testFrontier to productstore area:

cmsbuild · 2023-10-14T12:49:49Z

Pull request #188 was updated.

smuzaffar · 2023-10-25T15:24:11Z

please test for CMSSW_13_3_ROOT6_X

cmsbuild · 2023-10-25T18:54:37Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e3c07/35416/summary.html
COMMIT: 3690f4d
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/188/35416/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e3c07/35416/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e3c07/35416/git-merge-result

Build

I found compilation error when building:

>> Building binary testConditionDatabase_4
Copying tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testConditionDatabase_4/testConditionDatabase_4 to productstore area:
>> Compiling  /pool/condor/dir_19671/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-24-2300/src/CondCore/CondDB/test/testConnectionPool.cpp
>> Building binary testConnectionPool
/pool/condor/dir_19671/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCondFormatsRunInfo: No such file or directory
collect2: error: ld returned 1 exit status
>> Deleted: tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool
gmake: *** [tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool] Error 1
>> Compiling  /pool/condor/dir_19671/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-24-2300/src/CondCore/CondDB/test/testFrontier.cpp
>> Building binary testFrontier
Copying tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testFrontier/testFrontier to productstore area:

smuzaffar · 2023-10-26T08:51:52Z

please test for CMSSW_13_3_ROOT6_X

cmsbuild · 2023-10-26T13:49:05Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e3c07/35428/summary.html
COMMIT: 3690f4d
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/188/35428/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Building binary testConditionDatabase_4
Copying tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testConditionDatabase_4/testConditionDatabase_4 to productstore area:
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-25-2300/src/CondCore/CondDB/test/testConnectionPool.cpp
>> Building binary testConnectionPool
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCondFormatsRunInfo: No such file or directory
collect2: error: ld returned 1 exit status
>> Deleted: tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool
gmake: *** [tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool] Error 1
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_ROOT6_X_2023-10-25-2300/src/CondCore/CondDB/test/testFrontier.cpp
>> Building binary testFrontier
Copying tmp/el8_amd64_gcc12/src/CondCore/CondDB/test/testFrontier/testFrontier to productstore area:

smuzaffar · 2023-10-26T14:05:14Z

please test for CMSSW_13_3_ROOT6_X

cmsbuild · 2023-10-27T03:25:19Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e3c07/35435/summary.html
COMMIT: 3690f4d
CMSSW: CMSSW_13_3_ROOT6_X_2023-10-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/188/35435/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

Comparison Summary

Summary:

You potentially removed 177 lines from the logs
Reco comparison results: 3861 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3357400
DQMHistoTests: Total failures: 31355
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3326023
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: found differences in 1 / 48 workflows

iarspider · 2023-11-15T14:27:42Z

please test for CMSSW_13_3_ROOT6_X

hahnjo added 30 commits October 4, 2023 11:15

Import ROOT-llvm16-20231004-01

e8941e7

[interpreter] Require LLVM 16

7729241

[cling] TargetRegistry.h moved to MC/

2682b62

[cling] llvm::Optional::hasValue was renamed to has_value

167a2c6

[cling] LookupFile takes arguments as ConstSearchDirIterator

d087ea8

[cling] InclusionDirective takes an clang::OptionalFileEntryRef

eb06264

[cling] Update ClingMemoryManager with llvm::Align

26e810b

[cling] Misc renamings and type changes

4547571

[cling] Adapt arguments for updated APIs

d57c7c3

Forwarding data (differently) or passing trivial parameters.

[cling] CompoundStmt::Create takes FPOptionsOverride

550fbff

[cling] getQualifiedTemplateName takes a TemplateName

e771adb

[cling] SubstDefaultTemplateArgumentIfAvailable

ae0be65

... takes an additional vector for canonical arguments.

[cling] MultiLevelTemplateArgumentList

5219855

... takes a Decl and a boolean argument Final.

[cling] Some changes from JITEvaluatedSymbol to ExecutorAddr

ae42517

[cling] Adapt and heavily simplify ClingJITLinkMemoryManager

51e0c61

Now we can just inherit from InProcessMemoryManager and override the deallocate() method.

[cling] Lexer does not expose getLangOpts() anymore

cf48788

Store a reference ourselves. Also Lexer::isIdentifierBodyChar() was renamed to Lexer::isAsciiIdentifierContinueChar().

[cling] Update for new FileNotFound callback

974ec61

[cling] Update InvocationOptions

1641e9f

[cling] Resource directory based on major version only

ffed3db

[cling] Remove PMBuilder members

68615b5

These two fields don't exist anymore in LLVM 16.

[cling] Set MSVolatile in LangOpts

01234a2

[cling] Misc adaptations for updated APIs

a4e12c7

[cling] Don't print name of EnumDecl if there is none

968ae84

The function overload without PrintingPolicy is not available in LLVM 16, see https://reviews.llvm.org/D134813.

[cling] Adapt to updated forgetDecl signature

351cd26

The GlobalDecl parameter wasn't used since quite some time.

[cling] Remove extension of legacy pass manager

78b7dcf

adjustPassManager was only used for a few backends, such as AMDGPU and NVPTX, but not on the CPU architectures we care about. The DiscriminatorsPass was also removed upstream Clang, see commit llvm/llvm-project@2978d02681.

[cling] Update handling of ElaboratedType in GetFullyQualifiedType

ccc0332

In LLVM 16, we now get ElaboratedType far more often, but they don't have all namespace qualifiers we need. This fixes the build of the RooFitCore module, but many other places are likely affected as well.

[cling] Handle ElaboratedType in ReSubstTemplateArg

bc5fb71

In LLVM 16, we get ElaboratedType's in TemplateArgument's and need to recurse into them. This fixes the handling of Double32_t in the test roottest-root-io-double32-make.

[win64] Disable Cling optimizations

77f54af

With the upgrade to LLVM 16, we again have test failures due to crashes and output ordering compared to the reference files. This reverts commit 47277df.

Backport TLS PCREL relocation

3690f4d

cmsbuild added tests-pending and removed tests-rejected labels Oct 14, 2023

smuzaffar changed the base branch from cms/master/1a029b5 to cms/master/7740cca October 18, 2023 10:39

cmsbuild added tests-started tests-rejected and removed tests-pending tests-started labels Oct 25, 2023

smuzaffar changed the base branch from cms/master/7740cca to cms/master/9a4eeaa5ce October 26, 2023 08:49

cmsbuild added requires-external tests-started tests-rejected and removed tests-rejected tests-started labels Oct 26, 2023

cmsbuild added tests-started and removed tests-rejected labels Oct 26, 2023

cmsbuild added tests-rejected and removed tests-started labels Oct 27, 2023

cmsbuild added tests-pending and removed tests-rejected labels Nov 15, 2023

smuzaffar closed this Dec 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport jitlink ppc64 #188

Backport jitlink ppc64 #188

smuzaffar commented Oct 13, 2023

cmsbuild commented Oct 13, 2023

cmsbuild commented Oct 14, 2023

smuzaffar commented Oct 25, 2023

cmsbuild commented Oct 25, 2023

smuzaffar commented Oct 26, 2023

cmsbuild commented Oct 26, 2023

smuzaffar commented Oct 26, 2023

cmsbuild commented Oct 27, 2023

iarspider commented Nov 15, 2023

Backport jitlink ppc64 #188

Backport jitlink ppc64 #188

Conversation

smuzaffar commented Oct 13, 2023

cmsbuild commented Oct 13, 2023

Build

cmsbuild commented Oct 14, 2023

smuzaffar commented Oct 25, 2023

cmsbuild commented Oct 25, 2023

Build

smuzaffar commented Oct 26, 2023

cmsbuild commented Oct 26, 2023

Build

smuzaffar commented Oct 26, 2023

cmsbuild commented Oct 27, 2023

Unit Tests

Comparison Summary

iarspider commented Nov 15, 2023