Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix of path names in HLT Higgs validation code - 75X #9618

Merged
merged 2 commits into from
Jul 9, 2015
Merged

Fix of path names in HLT Higgs validation code - 75X #9618

merged 2 commits into from
Jul 9, 2015

Conversation

silviodonato
Copy link
Contributor

This PR fixes the trigger path names in the HLT validation code of Higgs group, accordingly to:
https://its.cern.ch/jira/browse/CMSHLT-405

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jun 15, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato for CMSSW_7_5_X.

Fix of path names in HLT Higgs validation code - 75X

It involves the following packages:

HLTriggerOffline/Higgs

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@silviodonato silviodonato mentioned this pull request Jun 15, 2015
Merged
@deguio
Copy link
Contributor

deguio commented Jun 17, 2015

please test

@deguio
Copy link
Contributor

deguio commented Jun 17, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild cmsbuild mentioned this pull request Jun 23, 2015
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

+1
Tested at: 916bce6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9618/188671/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jul 9, 2015
@cmsbuild
Merge pull request #9618 from silviodonato/DQM-higgs-btag-fix
3a668b9 
Fix of path names in HLT Higgs validation code - 75X
@cmsbuild cmsbuild merged commit 3a668b9 into cms-sw:CMSSW_7_5_X Jul 9, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9618/188671/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.
4 participants
@silviodonato @cmsbuild @deguio @davidlange6