Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to cvs head-V00-02-30 #96

Merged
merged 4 commits into from
Jul 29, 2013
Merged

Updating to cvs head-V00-02-30 #96

merged 4 commits into from
Jul 29, 2013

Conversation

inugent
Copy link
Contributor

@inugent inugent commented Jul 13, 2013

Updating Validation/EventGenerator to cvs head and to match 4_1_X and 4_4_X tags.

@cmsbuild
Copy link
Contributor

The following categories have been signed by ciulli (a.k.a. @vciulli on GitHub): Generators

@cms-git-generators

@davidlt
Copy link
Contributor

davidlt commented Jul 23, 2013

The following touched a lot of not needed files. I assume author checked out code from CVS and pushed to the GIT, thus all special CVS keywords were updated. That also creates merge conflicts. I would prefer all CVS related keywords to be removed completely.

@davidlt
Copy link
Contributor

davidlt commented Jul 23, 2013

Two items from my side:

  • Remove CVS keywords (revision, date) from Validation/EventGenerator/plugins/TauValidation.cc. We should remove such CVS keywords CMSSW scale in future.
  • Validation/EventGenerator/python/__init__.py is generated by SCRAM and should not be part of your change set. Remove it.

Make sure changes are done ASAP, as we need to get this integrated for 0200 AM IB.

@ghost ghost assigned davidlt Jul 26, 2013
@vciulli
Copy link
Contributor

vciulli commented Jul 26, 2013

David,
I guess you want me to reject the pull and sign it again once it is fixed.
I tried to reject it but I got an error and I am not sure if it worked.
Now I am no more able to see the pull list (I don't know why).

Vitaliano

@davidlt
Copy link
Contributor

davidlt commented Jul 26, 2013

@vciulli , now it looks good to me. There seems to be some issues with Topic Collector now. But written agreement of current content of the branch is fully enough. If you agree, I test it and integrate.

@vciulli
Copy link
Contributor

vciulli commented Jul 27, 2013

@davidlt. It's fine with me. Please go ahead.

@davidlt davidlt merged commit dd58de3 into cms-sw:CMSSW_6_2_X Jul 29, 2013
jshlee referenced this pull request in jshlee/cmssw Mar 7, 2014
nclopezo added a commit to nclopezo/cmssw that referenced this pull request Nov 21, 2014
run-pr-tests: Add _NPROCESSORS_ONLN to scram b
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Nov 23, 2014
new options for friendtrees (port to 7.0.X of Cristina's PR cms-sw#90)
gdimperi pushed a commit to gdimperi/cmssw that referenced this pull request Jun 21, 2015
add nominal pdf to shape1 type systematics
arizzi added a commit to arizzi/cmssw that referenced this pull request Jul 17, 2015
thomreis pushed a commit to thomreis/cmssw that referenced this pull request Nov 17, 2015
mverwe pushed a commit to mverwe/cmssw that referenced this pull request Nov 28, 2016
mariadalfonso added a commit to mariadalfonso/cmssw that referenced this pull request May 6, 2017
only tb signal, split by mass region -- 1 lepton
arizzi added a commit to arizzi/cmssw that referenced this pull request Jan 26, 2018
JME related additions and bug fixes
fwyzard pushed a commit to fwyzard/cmssw that referenced this pull request Jul 23, 2018
Return bool as the edm::Event::getByToken() does.
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants