-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality to compute signed IP wrt tau direction #9160
Conversation
A new Pull Request was created by @andrewj314 (AJ Johnson) for CMSSW_7_5_X. Added functionality to compute signed IP wrt tau direction It involves the following packages: DataFormats/TauReco @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Adding calculation of signed interaction point with respect to the tau direction. This PR should not alter other monitored quantities. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-07-02-2300 show no significant differences, as expected. The error that Jenkins notes above is a failure of unit tests for #9758, the 76X version of this PR. The error doesn't seem to be related to this PR. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Added functionality to compute signed IP wrt tau direction
…and also store 3D IP's