Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix online74 #9123

Closed
wants to merge 2 commits into from
Closed

Fix online74 #9123

wants to merge 2 commits into from

Conversation

deguio
Copy link
Contributor

@deguio deguio commented May 18, 2015

this is a bunch of fixes needed to have 74 working at p5.
the GT is updated as well.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio for CMSSW_7_4_X.

Fix online74

It involves the following packages:

DQM/DTMonitorModule
DQM/Integration
DQM/SiStripMonitorClient
RecoTauTag/Configuration

@nclopezo, @cvuosalo, @slava77, @cmsbuild, @deguio, @danduggan can you please review it and eventually sign? Thanks.
@jpavel, @threus, @batinkov, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor Author

deguio commented May 18, 2015

@diguida
we discussed already in person the bad behaviour of
loadRecoTauTagMVAsFromPrepDB_cfi.py

where the code is accessing frontier://FrontierProd/CMS_COND_PAT_000.
this doesn't work from inside p5 and this module is apparently included in some of the reco sequences run by the online applications.

how do you suggest to proceed here?
thanks in advance,
F.

@deguio
Copy link
Contributor Author

deguio commented May 18, 2015

commenting out everything is the temporary solution I put in place for 74, but it is not a final one.

@diguida
Copy link
Contributor

diguida commented May 18, 2015

@deguio
I have checked the sequences, but not the GT yet.
There are two issues here:

  1. (more serious) there is a new ESSource, without ESPrefer, while the only one reading conditions should be the PoolDBESSource instantiated in FrontierConditions_GlobalTag.
  2. (less serious) the logic of the fragment is not included in the payload loading.

I will give more information shortly.
@mmusich this is something you want to watch as well.

@jpavel
Copy link
Contributor

jpavel commented May 18, 2015

I think that part of the problem is that the payloads that are being loaded via this file are not included in any GT. Also, I think that by commenting this stuff, the tau sequence should fail, as these payloads are necessary for several discriminants. @andrewj314

@diguida
Copy link
Contributor

diguida commented May 18, 2015

@jpavel IIRC we added these corrections are already in some GT. We discussed this in an AlCaDB meeting, and even in person. Am I missing something?

@diguida
Copy link
Contributor

diguida commented May 18, 2015

@jpavel Anyhow, all the production sequences MUST consume conditions ONLY from GT. It is the only guaranteed way not to jeopardise reconstruction with incompatible calibrations.

@jpavel
Copy link
Contributor

jpavel commented May 18, 2015

They are in the production database. And AFAIK the last step is to include them in a queue the tag via GTC. This has not happened so far, as it was not clear to me which queue should be used.

@diguida
Copy link
Contributor

diguida commented May 18, 2015

@jpavel yes, indeed I have just found your question on private email in January (while I was sick).
From what I can see in the sequence, I assume that they are needed for both MC and data (including HLT), for Run1 and Run2 scenarios.

@jpavel
Copy link
Contributor

jpavel commented May 18, 2015

@diguida Yes - what are the names of the queues? 74Y_data_, 74Y_mc_ and 75Y_data* and 75Y_mc* ? I do not think it is needed for HLT, as the HLT discriminators are not using MVA (at least not at the moment).

@diguida
Copy link
Contributor

diguida commented May 18, 2015

@jpavel thanks!
The queues are:
74Y_designRun1
74Y_mcRun1
74Y_mcRun1_HeavyIon
74Y_mcRun1_pA
74Y_designRun2
74Y_mcRun2_startup
74Y_mcRun2_asymptotic
74Y_mcRun2_HeavyIon
74Y_dataExpress
74Y_dataPrompt
74Y_dataRun1
74Y_dataRun1RelVal
74Y_dataRun2
74Y_dataRun2RelVal
Same for 75X queues:
75Y_designRun1
75Y_mcRun1
75Y_mcRun1_HeavyIon
75Y_mcRun1_pA
75Y_designRun2
75Y_mcRun2_startup
75Y_mcRun2_asymptotic
75Y_mcRun2_HeavyIon
75Y_dataRun1
75Y_dataRun1RelVal
75Y_dataRun2
75Y_dataRun2RelVal

@jpavel
Copy link
Contributor

jpavel commented May 18, 2015

thanks, I submitted one tag to test the procedure. However, we have ~150 of those - is there a way how to automate the submission? CLI perhaps?

@slava77
Copy link
Contributor

slava77 commented May 18, 2015

Is this PR a work in progress?
From the comments earlier it sounds like it is and it's not worth reviewing/signing it yet.

@jpavel
Copy link
Contributor

jpavel commented May 19, 2015

@diguida Is the submission I made for one tag at the moment correct? Next, I cannot select a "record" for our payloads of type PhysicsTFormulaPayloadRcd and PhysicsTGraphPayloadRcd, so I cannot queue them. Were the new formats propagated to the tag collector?

@jpavel
Copy link
Contributor

jpavel commented May 19, 2015

@slava77 I think that it is work in progress - we need to include tau payloads to GT and I think that the PR at the moment breaks RECO sequence.

@cmsbuild
Copy link
Contributor

-1
Tested at: bdc9123
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 19-May-2015 14:01:58 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 19-May-2015 14:02:37 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT.log
----- Begin Fatal Exception 19-May-2015 14:03:02 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 194533 lumi: 329 event: 461582793
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 19-May-2015 14:09:33 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 19-May-2015 14:09:58 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23609118
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log
----- Begin Fatal Exception 19-May-2015 14:13:06 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 165121 lumi: 62 event: 23609118
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 19-May-2015 14:13:59 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 19-May-2015 14:13:59 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 191226 lumi: 398 event: 556818698
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log
----- Begin Fatal Exception 19-May-2015 14:14:34 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 19-May-2015 14:14:43 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log
----- Begin Fatal Exception 19-May-2015 14:28:21 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log
----- Begin Fatal Exception 19-May-2015 14:31:51 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module PFRecoTauDiscriminationAgainstElectronMVA5/'hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
No data of type "GBRForest" with label "RecoTauTag_antiElectronMVA5v1_gbr_NoEleMatch_woGwoGSF_BL" in record "GBRWrapperRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9123/9456/summary.html

@deguio
Copy link
Contributor Author

deguio commented May 19, 2015

-1
this won't be tested as it is. this is work ongoing.
F.

@slava77
Copy link
Contributor

slava77 commented May 21, 2015

Is this still in a "work ongoing" status?

@deguio
Copy link
Contributor Author

deguio commented May 22, 2015

ciao @slava77
an update about this is that for the online, where the full reco sequence is run for the EvD and other applications, I managed to get the code working by using a TauID.db as an input locally.
this is a temporary solution. I let @diguida and @jpavel converge on a final fix for this.

closing.
ciao,
F.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants