Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new code to make validation plots #74

Closed
wants to merge 1 commit into from

Conversation

acaudron
Copy link

These changes are only affecting offline scripts to be used to produce some validation plots from DQM root files.

@ktf
Copy link
Contributor

ktf commented Jul 10, 2013

@rovere @deguio can you look into this and eventually approve? Thanks.

@ktf
Copy link
Contributor

ktf commented Jul 10, 2013

BTW, @acaudron I just noticed this development is for CMSSW_6_2_X, not CMSSW_7_0_X. While the plan is to open also the former in git tomorrow, are you sure you did not want it for the latter?

@rovere
Copy link
Contributor

rovere commented Jul 10, 2013

@ktf the plan was to have this included in pre8, so that we would have had it for free in 700pre0, but that did not happen. It's not true, it's a lie ... but I'm sure @acaudron will exercise git and pull it also for 70X.

@ktf while we appreciate your attachment to the release, we were wondering if we will receive the new equivalent of BUMP for all the pull requests ;) 'Cause we are kind of settling down on a twice-a-week procedure to test pull requests, maybe out of sync with your reminders.

@acaudron
Copy link
Author

@ktf , @rovere I add these changes in the pull request I queued for 70X. But if possible, I will appreciate if it could be include also in 62x. As I said, the modifications concern only script in the script/ and test/ directories which then are not affecting the DQM/Validation code directly but are really useful for release validation.
It was also for me, the good occasion to try git for CMSSW.

@ktf the next time I will follow your request for the commit log. Is there any documentation about this that I missed ?

@ktf
Copy link
Contributor

ktf commented Jul 11, 2013

@acaudron Sounds good. I just wanted to make sure the changes were queued correctly, since the procedure is new. CMSSW_6_2_X will be opened in git later today. I will approve them then.

@ktf
Copy link
Contributor

ktf commented Aug 2, 2013

Is this still active?

@acaudron
Copy link
Author

acaudron commented Aug 2, 2013

yes as not yet included in the 62x releases

@ktf
Copy link
Contributor

ktf commented Aug 2, 2013

@rovere @deguio can you please review and approve if needed?

@deguio
Copy link
Contributor

deguio commented Aug 2, 2013

ciao,
for some reason the cms-merge-topic command doesn't work with the pull request #74
do you have suggestions?

scram project -n CMSSW_6_2_0_ID74-108-137 CMSSW_6_2_0
cd CMSSW_6_2_0_ID74-108-137/src/
cmsenv
git cms-merge-topic 74

No release tags specified, using default CMSSW_6_2_0.
You are on branch CMSSW_6_2_X
Checking out FWCore/Version in tag CMSSW_6_2_0.
Cloning into '/build/deguio/releaseIntegration/62X/22072013/CMSSW_6_2_0_ID74-108-137/src'...
remote: Counting objects: 264, done.
remote: Compressing objects: 100% (50/50), done.
remote: Total 70 (delta 60), reused 29 (delta 19)
Unpacking objects: 100% (70/70), done.
Branch from-CMSSW_6_2_0 set up to track remote branch CMSSW_6_2_X from official-cmssw.
Switched to a new branch 'from-CMSSW_6_2_0'
HEAD is now at 83a929a This commit was manufactured by cvs2git to create tag 'CMSSW_6_2_0'.
From .
*[new ref] -> merge-attempt
From https://github.com/cms-sw/cmssw
*[new ref] refs/pull/74/head -> cms-sw/refs/pull/74/head
Switched to branch 'merge-attempt'

git branch
CMSSW_7_0_X
cms-sw/refs/pull/74/head
from-CMSSW_6_2_0
*merge-attempt

ls
FWCore

@acaudron
Copy link
Author

acaudron commented Aug 2, 2013

I'm not sure to understand what is the problem but if I can help somehow or make some tries on my side, please, let me know.

@eliasron
Copy link

eliasron commented Aug 7, 2013

Hi, it also doesn't seem to work for me in 62X:

No release tags specified, using default CMSSW_6_2_X_2013-08-06-0200.
You are on branch CMSSW_6_2_X
Checking out FWCore/Version in tag CMSSW_6_2_X_2013-08-06-0200.
Cloning into '/afs/cern.ch/user/e/eron/DQM/CMSSW_6_2_X_2013-08-06-0200/src'...
remote: Counting objects: 7, done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 3 (delta 2), reused 2 (delta 1)
Unpacking objects: 100% (3/3), done.
Branch from-CMSSW_6_2_X_2013-08-06-0200 set up to track remote branch CMSSW_6_2_X from official-cmssw.
Switched to a new branch 'from-CMSSW_6_2_X_2013-08-06-0200'
HEAD is now at af74986 Merge pull request #199 from davidlange6/fix_to_dqm_crash_in_postls1
From .

@ktf
Copy link
Contributor

ktf commented Aug 9, 2013

@acaudron can you try following:

http://cms-sw.github.io/cmssw/tutorial-forward-port.html

and see if you can resolve the conflicts?

@ghost ghost assigned acaudron Aug 9, 2013
@acaudron
Copy link
Author

acaudron commented Aug 9, 2013

@ktf :
I tried the tutorial with but when I do
git cms-merge-topic acaudron:newvalidationscripts
I got

No release tags specified, using default CMSSW_6_2_X_2013-08-08-1400.
You are on branch CMSSW_6_2_X
Checking out FWCore/Version in tag CMSSW_6_2_X_2013-08-08-1400.
Cloning into '/afs/cern.ch/work/a/acaudron/CMSSW/CMSSW_6_2_X_2013-08-08-1400/src'...
remote: Counting objects: 451, done.
remote: Compressing objects: 100% (149/149), done.
remote: Total 206 (delta 157), reused 104 (delta 57)
Receiving objects: 100% (206/206), 48.10 KiB | 0 bytes/s, done.
Resolving deltas: 100% (157/157), completed with 101 local objects.
Branch from-CMSSW_6_2_X_2013-08-08-1400 set up to track remote branch CMSSW_6_2_X from official-cmssw.
Switched to a new branch 'from-CMSSW_6_2_X_2013-08-08-1400'
HEAD is now at af74986 Merge pull request #199 from davidlange6/fix_to_dqm_crash_in_postls1
From .

I think that is the same problems as yours. What should be a correct output ?

@ghost ghost assigned ktf Aug 9, 2013
@cmsbuild
Copy link
Contributor

The following categories have been signed by @deguio: DQM

@cms-git-dqm

@deguio
Copy link
Contributor

deguio commented Aug 23, 2013

finally tested and signed.
thanks to @acaudron @ktf

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes.

@ktf
Copy link
Contributor

ktf commented Aug 23, 2013

yes, but now this cannot be merged anymore. Can you please rebase it?

@fabiocos
Copy link
Contributor

+1

@ktf
Copy link
Contributor

ktf commented Sep 23, 2013

Closing this since it's now obsolete.

@ktf ktf closed this Sep 23, 2013
nclopezo added a commit to nclopezo/cmssw that referenced this pull request Nov 21, 2014
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Nov 23, 2014
make running on MINIAOD cfg FullHad and Singlelepton
gdimperi pushed a commit to gdimperi/cmssw that referenced this pull request Jun 21, 2015
…lopment

Tool to get a report on the systematics in a card and their correlations
arizzi added a commit to arizzi/cmssw that referenced this pull request Jun 23, 2015
gflouris pushed a commit to gflouris/cmssw that referenced this pull request Oct 28, 2015
…generic_TF_unpacker

Tested with buffer dump from MP7 at P5 and with RAW generated from rx/tx files
mverwe pushed a commit to mverwe/cmssw that referenced this pull request Apr 5, 2016
bianchini pushed a commit to bianchini/cmssw that referenced this pull request Jun 16, 2016
tstreble pushed a commit to tstreble/cmssw that referenced this pull request Nov 20, 2017
felicepantaleo pushed a commit to felicepantaleo/cmssw that referenced this pull request Jun 8, 2018
Run the `thrust::exclusive_scan` within the given CUDA stream.
This improves the overall synchronisation, replacing calls to `cudaDeviceSynchronize` with calls to `cudaStreamSynchronize`.
cmsbuild pushed a commit that referenced this pull request Apr 6, 2019
franzoni pushed a commit to franzoni/cmssw that referenced this pull request May 3, 2021
* allow gluons to be shot

* Extend Pythia8 gun description
tomalin pushed a commit to tomalin/cmssw that referenced this pull request May 18, 2021
* Anders DTC merge with a gazillion manual fixes

* propagate buildfile fixes

* code formats

* fix cherrypick  mess up

* Remove LayerProjection class

* Further cleanup of tracklet projections interface

* Correct number of processing steps by changing < to <=

* Add missing include of algorithm

* Remove extra const

* Remove some commented out code

* Remove duplicate code

* Fix message logger and DTC Stub for consistency with hybrid configuration

* Fix problem with writing of input link memories

* Create Residual class that will replace LayerResidual and DiskResidual

* Remove the use of the class DiskResiduals

* Remove unused nMatch and nMatchDisk method of Tracklet

* (Re-)Implement the correction to writing the DTC data link file after moving functionality to Sector.

* Combine addMatch method for disk and layers into on method

* combine the disk and layer match into one method

* Remove some redundant poiters to l1tstubs

* Pass iSeed to Tracklet

* Introduce an InputRouter module. Does not change functionality, but simplifies/unifies the code and makes it similar to the HLS

* Cleanup of writing the DTC link files

* Change processing order such that all steps in one sector are done and then move to the next sector. This saves memory

* Interface updates for CMSSW following change to module processing order

* Change in VMRouter to processing PS links before 2S in disks

* Cleanup of unused iSector variable in processs and memory modules

* Fixes to make the HybridTracks_cfg.py run

* Cleanup of hardcoded numbers etc.

* Updates to MP to put all regions into one memory slot in the ProjectionTemp

* Fix to calculation of irinv for projections - no matches what is done in HLS

* Remove now unused file paths for the old cable mapping code

* Correct missplaced curly bracket

* Fixes for the displaced tracking

* Fix to avoid duplicate VMSTE name in D1 for standard configuration

* Address comments from Louise S.

* Ran scram b code-format

* Address comments from Louise S.

* Addressing more comments from Louise S.

* More fixes to comments

* Make running hybrid default (not displaced)

* restore buildfile

* Add DTC link config to Settings.h

* Changes to suppress warning in MatchCalculator when running displaced tracking

* Fix typo introduced in code cleanup for MatchProcessor

Co-authored-by: Anders Ryd <[email protected]>
Co-authored-by: Anders <[email protected]>
cmsbuild pushed a commit that referenced this pull request Jul 7, 2021
* Anders DTC merge with a gazillion manual fixes

* propagate buildfile fixes

* code formats

* fix cherrypick  mess up

* Remove LayerProjection class

* Further cleanup of tracklet projections interface

* Correct number of processing steps by changing < to <=

* Add missing include of algorithm

* Remove extra const

* Remove some commented out code

* Remove duplicate code

* Fix message logger and DTC Stub for consistency with hybrid configuration

* Fix problem with writing of input link memories

* Create Residual class that will replace LayerResidual and DiskResidual

* Remove the use of the class DiskResiduals

* Remove unused nMatch and nMatchDisk method of Tracklet

* (Re-)Implement the correction to writing the DTC data link file after moving functionality to Sector.

* Combine addMatch method for disk and layers into on method

* combine the disk and layer match into one method

* Remove some redundant poiters to l1tstubs

* Pass iSeed to Tracklet

* Introduce an InputRouter module. Does not change functionality, but simplifies/unifies the code and makes it similar to the HLS

* Cleanup of writing the DTC link files

* Change processing order such that all steps in one sector are done and then move to the next sector. This saves memory

* Interface updates for CMSSW following change to module processing order

* Change in VMRouter to processing PS links before 2S in disks

* Cleanup of unused iSector variable in processs and memory modules

* Fixes to make the HybridTracks_cfg.py run

* Cleanup of hardcoded numbers etc.

* Updates to MP to put all regions into one memory slot in the ProjectionTemp

* Fix to calculation of irinv for projections - no matches what is done in HLS

* Remove now unused file paths for the old cable mapping code

* Correct missplaced curly bracket

* Fixes for the displaced tracking

* Fix to avoid duplicate VMSTE name in D1 for standard configuration

* Address comments from Louise S.

* Ran scram b code-format

* Address comments from Louise S.

* Addressing more comments from Louise S.

* More fixes to comments

* Make running hybrid default (not displaced)

* restore buildfile

* Add DTC link config to Settings.h

* Changes to suppress warning in MatchCalculator when running displaced tracking

* Fix typo introduced in code cleanup for MatchProcessor

Co-authored-by: Anders Ryd <[email protected]>
Co-authored-by: Anders <[email protected]>
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Sep 28, 2021
Upstream updates of track and muon word
yulunmiao pushed a commit to yulunmiao/cmssw that referenced this pull request Oct 4, 2023
…O-13_2_0_pre3_feat

DQM+Reco for single modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants