-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TriggerResultFilters: accept arbitrary Path names #7108
TriggerResultFilters: accept arbitrary Path names #7108
Conversation
fwyzard
commented
Jan 9, 2015
- accept arbitrary Path names
- rename the internal classes for consistency
- update test files for the new functionality
- prevent segfault if an L1 trigger is used in the expression without passing the L1 results collection
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X. TriggerResultFilters: accept arbitrary Path names It involves the following packages: HLTrigger/HLTcore @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
please test |
The tests are being triggered in jenkins |
-1 runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log 5.1 step1 runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log 8.0 step1 runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log ----- Begin Fatal Exception 12-Jan-2015 08:33:46 CET----------------------- An exception of category 'ConfigFileReadError' occurred while [0] Processing the python configuration file named BeamHalo_cfi_py_GEN_SIM.py Exception Message: python encountered the error: edm::FileInPath unable to find file SimG4CMS/Calo/data/HFShowerLibrary_oldpmt_noatt_eta4_16en.root anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-11-0200/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-11-0200/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2015-01-11-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2015-01-11-0200/external/slc6_amd64_gcc491/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS ----- End Fatal Exception ------------------------------------------------- 9.0 step1 runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log ----- Begin Fatal Exception 12-Jan-2015 08:33:50 CET----------------------- An exception of category 'ConfigFileReadError' occurred while [0] Processing the python configuration file named H200ChargedTaus_Tauola_8TeV_cfi_GEN_SIM.py Exception Message: python encountered the error: edm::FileInPath unable to find file SimG4CMS/Calo/data/HFShowerLibrary_oldpmt_noatt_eta4_16en.root anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-11-0200/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-11-0200/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2015-01-11-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2015-01-11-0200/external/slc6_amd64_gcc491/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST ----- End Fatal Exception ------------------------------------------------- 25.0 step1 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log ----- Begin Fatal Exception 12-Jan-2015 08:33:51 CET----------------------- An exception of category 'ConfigFileReadError' occurred while [0] Processing the python configuration file named TTbar_8TeV_TuneCUETP8M1_cfi_GEN_SIM.py Exception Message: python encountered the error: edm::FileInPath unable to find file SimG4CMS/Calo/data/HFShowerLibrary_oldpmt_noatt_eta4_16en.root anywhere in the search path. The search path is defined by: CMSSW_SEARCH_PATH ${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-11-0200/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_4_X_2015-01-11-0200/external/slc6_amd64_gcc491/data:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2015-01-11-0200/src:/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2015-01-11-0200/external/slc6_amd64_gcc491/data Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT ----- End Fatal Exception ------------------------------------------------- 101.0 step1 runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log 1000.0 step2 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log 1001.0 step2 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log 1003.0 step2 runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log 50101.0 step2 runTheMatrix-results/50101.0_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS/step2_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS.log 1306.0 step2 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log 4.53 step3 runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT.log 25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing). |
-1 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log 25202.0 step3 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log you can see the results of the tests here: |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
TriggerResultFilters: accept arbitrary Path names
reverting so that I can revert the FSQ changes giving problems in the IBs (I think this will only revert the FSQ changes in this PR) |
OK, so only the FSQ stuff of this PR is actually reverted... |