Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated default btag discriminators for PAT jet #5729

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Oct 7, 2014

This is a follow-up to PR #5446 which adds new btag discriminators to the default PAT jet configuration.

Note that this PR requires 720pre7 RelVal samples for PAT tests not to fail.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_2_X.

Updated default btag discriminators for PAT jet

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@nhanvtran, @TaiSakuma, @mmarionncern, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

-1

Tested at: 62ebf38
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5729/1121/summary.html

@ferencek
Copy link
Contributor Author

ferencek commented Oct 8, 2014

@vadler Can you update the input files to 720pre7 RelVals? Thanks

@vadler
Copy link

vadler commented Oct 9, 2014

@ferencek : I'm doing this right now and will integrate your commit.

@vadler
Copy link

vadler commented Oct 9, 2014

@ferencek : This PR is superseded by #5760 now and can be closed. A corresponding 73X version is on the way.

@ferencek
Copy link
Contributor Author

ferencek commented Oct 9, 2014

Thanks. PR closed.

@ferencek ferencek closed this Oct 9, 2014
@ferencek ferencek deleted the PATJetBTagDiscriminatorsUpdate_from-CMSSW_7_2_0_pre7 branch October 9, 2014 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants