-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AK5 to AK4 migration with new Global Tags #5666
AK5 to AK4 migration with new Global Tags #5666
Conversation
…ng to fix various runtests by setting the GT to run2_mc
…ies runtest. Also fixing a couple of stray AK5s from python files more than one layer deep in the package
…T uncertainty test
A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_2_X. AK5 to AK4 migration with new Global Tags It involves the following packages: CommonTools/ParticleFlow @civanch, @diguida, @StoyanStoynev, @lveldere, @danduggan, @mdhildreth, @monttj, @cmsbuild, @cerminar, @nclopezo, @rcastello, @deguio, @slava77, @vadler, @ojeda, @rovere can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
the GT changes show up only in Run1 MC: everything significant seems to start from RPC hits, the effects then propagate downstream to muons (mostly feature-less change in chi2 and number of hits), with negligible changes further down in the PF candidates and later. Apparently, muons with most notable variations don't make it through PF selections. |
@slava77 |
@slava77 |
AK5 to AK4 migration with new Global Tags
@slava77 I cannot see the changes you describe in the comparison plots attached to this PR (namely 5.1, 25.0). Is there a way to reproduce them? |
I don't see diffs in 25.0 in the same place, but I have them in my local tests. Strange. My tests for the complete PR were run on 03-Oct-2014 around 9pm. @cmsbuild |
@slava77
No, the tag is there since 2012 and the Global Tag mapping is immutable. |
Merge of #5588 and #5662