Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard against blank lines in db.txt which cause tlf2esd.txt report to not be generated. #5637

Merged
merged 1 commit into from
Oct 2, 2014
Merged

guard against blank lines in db.txt which cause tlf2esd.txt report to not be generated. #5637

merged 1 commit into from
Oct 2, 2014

Conversation

gartung
Copy link
Member

@gartung gartung commented Oct 1, 2014

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2014

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_2_X.

guard against blank lines in db.txt which cause tlf2esd.txt report to not be generated.

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@gartung
Copy link
Member Author

gartung commented Oct 1, 2014

@Dr15Jones
Copy link
Contributor

+1
this is a bug fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. @nclopezo can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@gartung
Copy link
Member Author

gartung commented Oct 2, 2014

@ktf What is this waiting on? Should I submit to CMSSW_7_3_X queue instead?

@Dr15Jones
Copy link
Contributor

Since 7_2_X is closing, changes to 7_2_X now must be approved at a meeting held once a week on Tuesday. A seperate 7_3_X would get it into that release faster.

@ktf
Copy link
Contributor

ktf commented Oct 2, 2014

Indeed @Dr15Jones is right. For this particular case I guess we do not care, though. Please ping me explicitly whenever you have fixes for the static analyzer and I'll bypass the signatures.

ktf added a commit that referenced this pull request Oct 2, 2014
…t-gen

Guard against blank lines in db.txt which cause tlf2esd.txt report to not be generated.
@ktf ktf merged commit 4a44843 into cms-sw:CMSSW_7_2_X Oct 2, 2014
@gartung
Copy link
Member Author

gartung commented Oct 2, 2014

@ktf Will this get ported to 73X?

@ktf
Copy link
Contributor

ktf commented Oct 2, 2014

not in the short term, since there is a few conflicts between 72X and 73X which need to be resolved first. I'd do a separate pull request.

@gartung gartung deleted the clangSA-fix-data-products-report-gen branch October 3, 2014 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants