-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guard against blank lines in db.txt which cause tlf2esd.txt report to not be generated. #5637
guard against blank lines in db.txt which cause tlf2esd.txt report to not be generated. #5637
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_2_X. guard against blank lines in db.txt which cause tlf2esd.txt report to not be generated. It involves the following packages: Utilities/StaticAnalyzers @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
@ktf @Dr15Jones This fixes the bug that caused this file to be empty |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. @nclopezo can you please take care of it? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it? |
@ktf What is this waiting on? Should I submit to CMSSW_7_3_X queue instead? |
Since 7_2_X is closing, changes to 7_2_X now must be approved at a meeting held once a week on Tuesday. A seperate 7_3_X would get it into that release faster. |
Indeed @Dr15Jones is right. For this particular case I guess we do not care, though. Please ping me explicitly whenever you have fixes for the static analyzer and I'll bypass the signatures. |
…t-gen Guard against blank lines in db.txt which cause tlf2esd.txt report to not be generated.
@ktf Will this get ported to 73X? |
not in the short term, since there is a few conflicts between 72X and 73X which need to be resolved first. I'd do a separate pull request. |
No description provided.