-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIM Bug] Protection against geometry exceptions for HI simulations #47251
[SIM Bug] Protection against geometry exceptions for HI simulations #47251
Conversation
A new Pull Request was created by @civanch for CMSSW_13_0_HeavyIon_X. It involves the following packages:
@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
please test |
type bug-fix |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e180e9/44165/summary.html Comparison SummarySummary:
|
+1 the problem is relatively rare, so we observe full regression at small statistics. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_HeavyIon_X IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@CivanC There will also be MC production in 14_1_X for the 2024 campaign. Does it make sense to forward port this there? Or you prefer to wait for the master version and backport? |
@mandrenguyen , today understanding that it is not needed - the real problem was fixed earlier. |
There was just a new 13_0_X_HeavyIon release requested. Are you saying it's not needed? |
@mandrenguyen , sorry, I was not precise. This fix is needed as a patch to CMSSW_13_0_HeavyIon for all new requests of this campaign. What is not needed is the forward port of this fix to other releases. For newer production versions of CMSSW the fix is done already inside VecGeom. |
PR description:
In HI production there is a frequent problem due to possible overlap inside the tracker #47223. In this PR the energy threshold for the fatal exception is increased from 100 MeV to 1.5 GeV. This will reduce number of exceptions for Heavy Ion simulations with this version of production. This threshold means that the particle with energy below this threshold will be killed and the fatal exception will not be issued.
We will work on understanding of the problem in the master, the final fix may be different
PR validation:
private