Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIM Bug] Protection against geometry exceptions for HI simulations #47251

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Feb 3, 2025

PR description:

In HI production there is a frequent problem due to possible overlap inside the tracker #47223. In this PR the energy threshold for the fatal exception is increased from 100 MeV to 1.5 GeV. This will reduce number of exceptions for Heavy Ion simulations with this version of production. This threshold means that the particle with energy below this threshold will be killed and the fatal exception will not be issued.

We will work on understanding of the problem in the master, the final fix may be different

PR validation:

private

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

A new Pull Request was created by @civanch for CMSSW_13_0_HeavyIon_X.

It involves the following packages:

  • SimG4Core/Application (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @makortel, @martinamalberti, @rovere, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

cms-bot internal usage

@civanch
Copy link
Contributor Author

civanch commented Feb 3, 2025

please test

@civanch
Copy link
Contributor Author

civanch commented Feb 3, 2025

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e180e9/44165/summary.html
COMMIT: 1360b37
CMSSW: CMSSW_13_0_HeavyIon_X_2025-02-02-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47251/44165/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@civanch
Copy link
Contributor Author

civanch commented Feb 4, 2025

+1

the problem is relatively rare, so we observe full regression at small statistics.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_HeavyIon_X IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit edd75b5 into cms-sw:CMSSW_13_0_HeavyIon_X Feb 4, 2025
9 checks passed
@mandrenguyen
Copy link
Contributor

@CivanC There will also be MC production in 14_1_X for the 2024 campaign. Does it make sense to forward port this there? Or you prefer to wait for the master version and backport?

@civanch
Copy link
Contributor Author

civanch commented Feb 5, 2025

@mandrenguyen , today understanding that it is not needed - the real problem was fixed earlier.

@mandrenguyen
Copy link
Contributor

@mandrenguyen , today understanding that it is not needed - the real problem was fixed earlier.

There was just a new 13_0_X_HeavyIon release requested. Are you saying it's not needed?

@civanch
Copy link
Contributor Author

civanch commented Feb 5, 2025

@mandrenguyen , sorry, I was not precise. This fix is needed as a patch to CMSSW_13_0_HeavyIon for all new requests of this campaign. What is not needed is the forward port of this fix to other releases. For newer production versions of CMSSW the fix is done already inside VecGeom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants