[SIM/MTD] Fixed ECAL GFlash for Phase2 #47186
Conversation
|
cms-bot internal usage |
civanch
changed the title
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47186/43425 |
|
A new Pull Request was created by @civanch for master. It involves the following packages:
@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
simulation-approved
fully-signed
and removed
simulation-pending
pending-signatures
labels
|
+1 |
| @@ -131,6 +131,9 @@ int MtdSD::getTrackID(const G4Track* aTrack) { | |||
| edm::LogVerbatim("MtdSim") << "MtdSD: Track ID: " << aTrack->GetTrackID() | |||
| << " ETL Track ID: " << trkInfo->mcTruthID() << ":" << theID; | |||
| #endif | |||
| // In the case of ECAL GFlash fast spot may be inside MTD and should be ignored | |||
| } else if (rname == "EcalRegion") { | |||
There was a problem hiding this comment.
@civanch how does it happen that EcalRegion is found within MTD? Isn't this a bug?
PR description:
In the case of Phase2, there is a problem when fast energy spot appears outside ecal inside MTD sensitive detector. the probability of this is not high but previously this situation provided crash at SIM step. In this PR a protection is added.
this fix should not affect any production and any default WF.
PR validation:
private
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO backport