Fix compilation of HGCalRecHitProducers.cc

[iarspider]

PR description:

Title says it all. See build log link

PR validation:

Bot tests

[iarspider]

please test for CMSSW_15_0_DBG_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47179/43418

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47179/43418/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47179/43418/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[iarspider]

please test for CMSSW_15_0_DBG_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47179/43419

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• RecoLocalCalo/HGCalRecAlgos (upgrade, reconstruction)

@Moanwar, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @argiro, @bsunanda, @cseez, @denizsun, @edjtscott, @felicepantaleo, @hatakeyamak, @lgray, @missirol, @pfs, @rchatter, @rovere, @salimcerci, @sameasy, @sethzenz, @thomreis, @vandreev11, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0e068/43938/summary.html
COMMIT: 552d131
CMSSW: CMSSW_15_0_DBG_X_2025-01-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47179/43938/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 17096539 lines to the logs
• Reco comparison results: 50101 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3819085
• DQMHistoTests: Total failures: 130224
• DQMHistoTests: Total nulls: 67
• DQMHistoTests: Total successes: 3688774
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.21099999999999985 KiB( 48 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.192 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 13034.0 ): 1.259 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.771 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.469 KiB SiStrip/MechanicalView
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: found differences in 6 / 47 workflows

[pfs]

thank you @iarspider somehow this went unnoticed when our PR got integrated last week

[jfernan2]

+1

[iarspider]

@cms-sw/upgrade-l2 gentle ping

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1