Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETL simulation: update of TWC parameters #47172

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

24LopezR
Copy link
Contributor

PR description:

This PR aims to update the time walk correction parameters for ETL hit reconstruction, as a consequence of a bias observed in ETL time resolution [1].
TWC parameters have been recomputed to fit better the high statistics region. More details in [2].

[1] https://indico.cern.ch/event/1498634/#13-report-on-14_2_0_pre4-valid
[2] https://indico.cern.ch/event/1498383/#13-update-of-etl-time-walk-cor

PR validation:

PR has been validated with a sample of 1000 events of ttbar 14TeV.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not meant to be backported.

@fabiocos @martinamalberti

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @24LopezR for master.

It involves the following packages:

  • RecoLocalFastTime/FTLRecProducers (reconstruction, upgrade)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e5cbf/43937/summary.html
COMMIT: 8d1b33c
CMSSW: CMSSW_15_0_X_2025-01-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47172/43937/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@Moanwar
Copy link
Contributor

Moanwar commented Jan 24, 2025

+Upgrade

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4f16b1d into cms-sw:master Jan 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants