Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a Generic validation tool for dataset validation in the alignment all-in-one tool #47055

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 8, 2025

PR description:

This PR profits of two existing EDAnalyzers in Alignment/OfflineValidation: GeneralPurposeTrackAnalyzer and GeneralPurposeVertexAnalyzer to introduce a new "validation" flavour in the all-in-one tool called Generic in order to produce generic track and vertex quantities that is useful to cross-check to validate the content of datasets (be them real data or MC).
I provide here full interlacing with the all-in-one meta-tool and updated documentation. The unit tests of the package are updated accordingly. I profit of this PR to introduce few improvements in GeneralPurposeVertexAnalyzer via commit a3a7371.

PR validation:

scram b runtests_Genericall runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, can be backported if there is interest.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@adewit, @mmusich, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb6a36/43667/summary.html
COMMIT: b6031b0
CMSSW: CMSSW_15_0_X_2025-01-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47055/43667/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Jan 9, 2025

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants