Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-up unused inclusions in HLT paths in Phase2 HLT menu #46976

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 17, 2024

PR description:

Prompted by #46924 (comment) I went through the phase-2 HLT menu with the following script and discovered that some of the inclusions in the paths are inconsequential.
I propose to clean-up these includes in the menu.

PR validation:

Tested successfully:

  • hltPhase2UpgradeIntegrationTests
  • runTheMatrix.py -l 29634.75

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46976/43055

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 17, 2024

test parameters:

  • enable = hlt_p2_integration

@mmusich
Copy link
Contributor Author

mmusich commented Dec 17, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2aa69d/43503/summary.html
COMMIT: cd03533
CMSSW: CMSSW_15_0_X_2024-12-17-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46976/43503/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Dec 18, 2024

+hlt

@mmusich
Copy link
Contributor Author

mmusich commented Dec 18, 2024

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@mmusich mmusich force-pushed the mm_ph2_hlt_clean-up branch from cd03533 to 0ae08d2 Compare December 20, 2024 10:23
@mmusich
Copy link
Contributor Author

mmusich commented Dec 20, 2024

unhold

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46976 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 20, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2aa69d/43586/summary.html
COMMIT: 0ae08d2
CMSSW: CMSSW_15_0_X_2024-12-19-2300/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46976/43586/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2aa69d/43586/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2aa69d/43586/git-merge-result

Unit Tests

I found 5 errors in the following unit tests:

---> test GeometryMTDNumberingBuilderTestDriver had ERRORS
---> test GeometryMTDCommonDataTestDriver had ERRORS
---> test RecoMTDDetLayersTestDriver had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially removed 197 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12086 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3818210
  • DQMHistoTests: Total failures: 62726
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3755458
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1245.5199999999998 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 22.162 KiB EcalBarrel/EBClusterTask
  • DQMHistoSizes: changed ( 1000.0,... ): 8.976 KiB EcalEndcap/EEClusterTask
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 4 / 47 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Dec 21, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2aa69d/43593/summary.html
COMMIT: 0ae08d2
CMSSW: CMSSW_15_0_X_2024-12-20-2300/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46976/43593/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Dec 22, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b523ab3 into cms-sw:master Dec 22, 2024
13 checks passed
@mmusich mmusich deleted the mm_ph2_hlt_clean-up branch December 22, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants