-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean-up unused inclusions in HLT paths in Phase2 HLT menu #46976
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46976/43055
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild, please test |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
+hlt |
hold
|
Pull request has been put on hold by @mmusich |
cd03533
to
0ae08d2
Compare
unhold |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46976/43124 |
Pull request #46976 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again. |
@cmsbuild, please test |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 5 errors in the following unit tests: ---> test GeometryMTDNumberingBuilderTestDriver had ERRORS ---> test GeometryMTDCommonDataTestDriver had ERRORS ---> test RecoMTDDetLayersTestDriver had ERRORS and more ... Comparison SummarySummary:
|
please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
+hlt |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Prompted by #46924 (comment) I went through the phase-2 HLT menu with the following script and discovered that some of the inclusions in the paths are inconsequential.
I propose to clean-up these includes in the menu.
PR validation:
Tested successfully:
hltPhase2UpgradeIntegrationTests
runTheMatrix.py -l 29634.75
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A