Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1] Backport 46574: Rework Muon candidate selection in few tracker ALCARECO #46968

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

srimanob
Copy link
Contributor

PR description:

Backport of #46574

PR validation:

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2024

A new Pull Request was created by @srimanob for CMSSW_14_1_X.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)
  • Calibration/TkAlCaRecoProducers (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@adewit, @mmusich, @pakhotin, @rsreds, @threus, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2024

cms-bot internal usage

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@perrotta
Copy link
Contributor

Thank you @srimanob for having taken care of the backport!

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor

mmusich commented Dec 17, 2024

type performance-improvements

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61b800/43486/summary.html
COMMIT: fb4c4b9
CMSSW: CMSSW_14_1_X_2024-12-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46968/43486/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565709
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3565652
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.047 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -0.023 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): -0.023 KiB MessageLogger/Warnings
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@mandrenguyen
Copy link
Contributor

backport of #46574

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fe0f70e into cms-sw:CMSSW_14_1_X Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants