Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD geometry: activate the reordering of MTD reconstruction geometry #46963

Closed
wants to merge 1 commit into from

Conversation

fabiocos
Copy link
Contributor

PR description:

This reverts commit 06d30e1 and activates the new order in BTL reconstruction geometry from -pi to pi, aligning the order of BTL modules in MTD geometry and the tracking navigation geometry in RecoMTD/DetLayers.
It is integrated on top of #46911 , and it requires the update of the unit test references. This update is proposed in parallel to the update of the BTL numbering scheme, that also requires the update of all references.

PR validation:

Code compiles, runs and provide the desired order in the output MTDgeometry for the BTL part.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 16, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

  • Geometry/MTDNumberingBuilder (geometry, upgrade)
  • RecoMTD/DetLayers (upgrade, reconstruction)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @martinamalberti, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @fabiocos
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Dec 16, 2024
@fabiocos
Copy link
Contributor Author

This code will be directly integrated in the update of the numbering scheme

@fabiocos fabiocos closed this Dec 17, 2024
@fabiocos fabiocos deleted the fc-mtdtopofinal branch December 17, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants