Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMSSW_FULL_RELEASE_BASE in to valid cmssw import paths #46955

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

smuzaffar
Copy link
Contributor

Fixes #46937

CMSSW_FULL_RELEASE_BASE is also a valid cmssw path specially when one has created a dev area based on a patch release.

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Dec 16, 2024
@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = FWCore

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 16, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46955/43019

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • FWCore/ParameterSet (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar smuzaffar changed the title Added CMSSW_FULL_RELEASE_BASE in to allowed cmssw import paths Added CMSSW_FULL_RELEASE_BASE in to valid cmssw import paths Dec 16, 2024
@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7428a8/43461/summary.html
COMMIT: e665892
CMSSW: CMSSW_15_0_X_2024-12-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46955/43461/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMOfflineConfigurationGotAll had ERRORS

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 481
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3509516
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@makortel
Copy link
Contributor

Comparison differences are related to #46416

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@makortel
Copy link
Contributor

ignore tests-rejected with ib-failure

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3c8bc13 into cms-sw:master Dec 16, 2024
11 of 12 checks passed
smuzaffar added a commit to cms-sw/cmsdist that referenced this pull request Dec 17, 2024
…module

As cms-sw/cmssw#46955 has been merged , so we can enable the usage of realpth for cmssw python package imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParameterSet/python/Config.py does not allow full release imports
4 participants