Fix HOST_DEVICE_CONSTANT macro for AMD GPUs [14.2.x]

[fwyzard]

PR description:

Fix HOST_DEVICE_CONSTANT macro for AMD GPUs using HIP/ROCm as well as NVIDIA GPUs using CUDA.

Targets using SYCL can correctly fall back to the constexpr case.

PR validation:

None.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport #46952 to 14.2.x releases to fix AMD GPU back-ends.

[fwyzard]

backport #46952

[fwyzard]

type bugfix

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

A new Pull Request was created by @fwyzard for CMSSW_14_2_X.

It involves the following packages:

• FWCore/Utilities (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@felicepantaleo, @makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix HOST_DEVICE_CONSTANT macro for AMD GPUs #46952

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df0cd4/43454/summary.html
COMMIT: 7cfb11e
CMSSW: CMSSW_14_2_X_2024-12-15-0000/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46953/43454/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 36 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 1874
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3481828
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• You potentially removed 13 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 53058
• DQMHistoTests: Total failures: 57
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 53001
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 24 log files, 30 edm output root files, 7 DQM output files
• TriggerResults: no differences found

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1