Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 14_2_X (1/N) #46939

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 13, 2024

backport of #46938

PR description:

Development of HLT menus for CMSSW_14_2_X:

  • This is the PR for the CMSSW_14_2_X branch (this is the release cycle currently used for Run-3 HLT-menu development).
  • These updates correspond to the first batch of changes accumulated in the 14_2_X release cycle targeting the 2025 HLT menus. We start by migrating all sub-tables to CMSSW_14_2_0 template, remove customisations for 14_2_X and update get*HLT.sh scripts

This update includes the integration of the following JIRA tickets:

  • CMSHLT-3402 [DQM,BTV] Product to be added in EventContent to solve empty online DQM plots: BTV
  • CMSHLT-3403 [TRK,AlCa] Request to add HLT_IsoMu24_* and HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_* to hltDatasetHLTMonitor
  • CMSHLT-3405 [TSG] Backport of latest online updates to TrackerVR menu
  • CMSHLT-3406 [TSG,DQM] Remove unneeded output collections from hltOutputDQMGPUvsCPU
  • CMSHLT-3407 [HIN] Removal of HLT_PPRefDmesonTrackingGlobal_Dpt* and HLT_HICsAK4PFJet* triggers from the combined table

In addition, the following changes are included:

  • 83963d9: update input files for TSG tests to more modern datasets Run2024I
  • f0e3769: update hltPathOwners.json and README file

PR validation:

TSG integration tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #46938 to CMSSW_14_2_X (current branch of HLT development)

Migrate all sub-tables to CMSSW_14_2_0 template, remove customisation for 14_2_X and update get*HLT.sh scripts
These updates correspond to the first batch of changes accumulated in the 14_2_X release cycle targeting the 2025 HLT menus
This update includes the integration of the following JIRA tickets:

- [CMSHLT-3402](https://its.cern.ch/jira/browse/CMSHLT-3402) [DQM,BTV] Product to be added in EventContent to solve empty online DQM plots: BTV
- [CMSHLT-3403](https://its.cern.ch/jira/browse/CMSHLT-3403) [TRK,AlCa] Request to add HLT_IsoMu24_* and HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_* to hltDatasetHLTMonitor
- [CMSHLT-3405](https://its.cern.ch/jira/browse/CMSHLT-3405) [TSG] Backport of latest online updates to TrackerVR menu
- [CMSHLT-3406](https://its.cern.ch/jira/browse/CMSHLT-3406) [TSG,DQM] Remove unneeded output collections from hltOutputDQMGPUvsCPU
- [CMSHLT-3407](https://its.cern.ch/jira/browse/CMSHLT-3407) [HIN] Removal of HLT_PPRefDmesonTrackingGlobal_Dpt* and HLT_HICsAK4PFJet* triggers from the combined table
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2024

A new Pull Request was created by @mmusich for CMSSW_14_2_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Dec 13, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Dec 13, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 1368KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e588fe/43445/summary.html
COMMIT: 6bbbb28
CMSSW: CMSSW_14_2_X_2024-12-13-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46939/43445/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483714
  • DQMHistoTests: Total failures: 487
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3483207
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.11199999999999999 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 139.001,... ): -0.001 KiB HLT/Filters
  • DQMHistoSizes: changed ( 16834.0,... ): 0.023 KiB HLT/Filters
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 2 / 44 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53058
  • DQMHistoTests: Total failures: 32
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 53026
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Dec 14, 2024

type hlt-integration

@mmusich
Copy link
Contributor Author

mmusich commented Dec 16, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8813391 into cms-sw:CMSSW_14_2_X Dec 16, 2024
12 checks passed
@mmusich mmusich deleted the HLTdevelopment142X branch December 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants