Update clang-tidy test

[smuzaffar]

PGO changes ( e.g. using relative source path instead of full path ) broke scram build code-checks rule. So it has not been running properly on PR. code-format was working but only code-checks i.e. clang-tidy did not work as it required correct compiler_command.json with correct source file paths.

Updated clang-tidy unit test now makes sure

• scram build code-checks and scram build code-checks-all rules work correctly
• scram build code-format-all also works

This will require also cmsdist update with correct code-checks rule

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test

though test will fail as currently code-checks is not working correctly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46930/42997

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• Utilities/ReleaseScripts (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test with cms-sw/cmsdist#9575

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46930/43000

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Utilities/ReleaseScripts/test/test-clang-tidy.sh modified in PR(s): [Do not merge]Testing draft PR #46933

[cmsbuild]

Pull request #46930 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46930/43060

[cmsbuild]

Pull request #46930 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46930/43066

[cmsbuild]

Pull request #46930 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

[smuzaffar]

please test

[cmsbuild]

REMINDER @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with cms-sw/cmsdist#9584, please check if they should be merged together

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df69a6/43524/summary.html
COMMIT: dedd6c5
CMSSW: CMSSW_15_0_X_2024-12-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46930/43524/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3510017
• DQMHistoTests: Total failures: 490
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3509507
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@makortel , this is ready to go in. It add a new unit tests which makes sure that scram build code-checks and scram build code-format rules are working properly.

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1