Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.2.X]Fix for importing ClassesDefXmlUtils #46921

Merged

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Dec 12, 2024

backport of #46919
This should fix the patch build errors like

>> Checking EDM Class Version for src/AnalysisDataFormats/SUSYBSMObjects/src/classes_def.xml in libAnalysisDataFormatsSUSYBSMObjects.so
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-12-08-0000/src/FWCore/Reflection/scripts/edmCheckClassVersion -l libAnalysisDataFormatsSUSYBSMObjects.so -x /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/51a12ecc6fa5b95709134408c954413b/opt/cmssw/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-12-11-2300/src/AnalysisDataFormats/SUSYBSMObjects/src/classes_def.xml
Traceback (most recent call last):
  File "/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-12-08-0000/src/FWCore/Reflection/scripts/edmCheckClassVersion", line 4, in <module>
    import FWCore.Reflection.ClassesDefXmlUtils as ClassesDefUtils
ModuleNotFoundError: No module named 'FWCore.Reflection.ClassesDefXmlUtils'

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2024

A new Pull Request was created by @smuzaffar for CMSSW_14_2_X.

It involves the following packages:

  • FWCore/Reflection (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2024

cms-bot internal usage

@smuzaffar smuzaffar changed the title 142x fix import classes def xml utils [14.2.X]Fix for importing ClassesDefXmlUtils Dec 12, 2024
@smuzaffar
Copy link
Contributor Author

test parameters:

  • addpkg = DataFormats/Common

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19ac33/43401/summary.html
COMMIT: fcb4a5b
CMSSW: CMSSW_14_2_X_2024-12-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46921/43401/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483722
  • DQMHistoTests: Total failures: 486
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3483216
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@makortel
Copy link
Contributor

+core

@makortel
Copy link
Contributor

Comparison differences are related to #46416

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cc91330 into cms-sw:CMSSW_14_2_X Dec 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants